diff options
Diffstat (limited to 'src/tools/skylark/java')
-rw-r--r-- | src/tools/skylark/java/com/google/devtools/skylark/skylint/StatementWithoutEffectChecker.java | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/tools/skylark/java/com/google/devtools/skylark/skylint/StatementWithoutEffectChecker.java b/src/tools/skylark/java/com/google/devtools/skylark/skylint/StatementWithoutEffectChecker.java index 3e50ae4587..7ec1b4c23b 100644 --- a/src/tools/skylark/java/com/google/devtools/skylark/skylint/StatementWithoutEffectChecker.java +++ b/src/tools/skylark/java/com/google/devtools/skylark/skylint/StatementWithoutEffectChecker.java @@ -81,7 +81,11 @@ public class StatementWithoutEffectChecker extends SyntaxTreeVisitor { // list] return; } - issues.add(Issue.create(NO_EFFECT_CATEGORY, "expression result not used", node.getLocation())); + String message = "expression result not used"; + if (expr instanceof ListComprehension && !topLevel) { + message += ". Use a for-loop instead instead of a list comprehension."; + } + issues.add(Issue.create(NO_EFFECT_CATEGORY, message, node.getLocation())); } @Override |