diff options
| author |  fzaiser <fzaiser@google.com> | 2017-10-29 23:50:55 -0400 |
|---|---|---|
| committer |  John Cater <jcater@google.com> | 2017-10-30 10:41:50 -0400 |
| commit | bfabeff7d8223b3b84a6ccba41bbed7d393dff36 (patch) | |
| tree | 80fd47ef932c8b24d267c526f5524cc029ac290f /src/tools/skylark/java | |
| parent | f8db228498845a58eca980e5855e0caa464dd646 (diff) | |
Skylint: improve message for unused list comprehensions.
RELNOTES: none
PiperOrigin-RevId: 173846739
Diffstat (limited to 'src/tools/skylark/java')
| -rw-r--r-- | src/tools/skylark/java/com/google/devtools/skylark/skylint/StatementWithoutEffectChecker.java | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/tools/skylark/java/com/google/devtools/skylark/skylint/StatementWithoutEffectChecker.java b/src/tools/skylark/java/com/google/devtools/skylark/skylint/StatementWithoutEffectChecker.java index 3e50ae4587..7ec1b4c23b 100644 --- a/src/tools/skylark/java/com/google/devtools/skylark/skylint/StatementWithoutEffectChecker.java +++ b/src/tools/skylark/java/com/google/devtools/skylark/skylint/StatementWithoutEffectChecker.java @@ -81,7 +81,11 @@ public class StatementWithoutEffectChecker extends SyntaxTreeVisitor { // list] return; } - issues.add(Issue.create(NO_EFFECT_CATEGORY, "expression result not used", node.getLocation())); + String message = "expression result not used"; + if (expr instanceof ListComprehension && !topLevel) { + message += ". Use a for-loop instead instead of a list comprehension."; + } + issues.add(Issue.create(NO_EFFECT_CATEGORY, message, node.getLocation())); } @Override |