diff options
Diffstat (limited to 'src/test/java/com/google/devtools/build/lib/rules')
3 files changed, 13 insertions, 4 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/rules/ToolchainTypeTest.java b/src/test/java/com/google/devtools/build/lib/rules/ToolchainTypeTest.java index 7f043258e1..9b6cc4995c 100644 --- a/src/test/java/com/google/devtools/build/lib/rules/ToolchainTypeTest.java +++ b/src/test/java/com/google/devtools/build/lib/rules/ToolchainTypeTest.java @@ -18,6 +18,7 @@ import static com.google.common.truth.Truth.assertThat; import com.google.devtools.build.lib.analysis.ConfiguredTarget; import com.google.devtools.build.lib.analysis.TemplateVariableInfo; import com.google.devtools.build.lib.analysis.util.BuildViewTestCase; +import com.google.devtools.build.lib.testutil.TestConstants; import org.junit.Test; import org.junit.runner.RunWith; import org.junit.runners.JUnit4; @@ -25,11 +26,19 @@ import org.junit.runners.JUnit4; /** Unit tests for the {@code toolchain_type} rule. */ @RunWith(JUnit4.class) public class ToolchainTypeTest extends BuildViewTestCase { + @Test public void testSmoke() throws Exception { - ConfiguredTarget cc = getConfiguredTarget(getRuleClassProvider().getToolsRepository() - + "//tools/cpp:toolchain_type"); + ConfiguredTarget cc = + getConfiguredTarget(TestConstants.TOOLS_REPOSITORY + "//tools/cpp:toolchain_type"); assertThat(cc.get(TemplateVariableInfo.PROVIDER).getVariables()) .containsKey("TARGET_CPU"); } + + @Test + public void testCcToolchainDoesNotProvideJavaMakeVariables() throws Exception { + ConfiguredTarget cc = + getConfiguredTarget(TestConstants.TOOLS_REPOSITORY + "//tools/cpp:toolchain_type"); + assertThat(cc.get(TemplateVariableInfo.PROVIDER).getVariables()).doesNotContainKey("JAVABASE"); + } } diff --git a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcCommonTest.java b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcCommonTest.java index e966cc06c2..f6e711970e 100644 --- a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcCommonTest.java +++ b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcCommonTest.java @@ -969,7 +969,7 @@ public class CcCommonTest extends BuildViewTestCase { @Override public Metadata getMetadata() { return Metadata.builder() - .name("toolchain_type") + .name("cc_toolchain_type") .factoryClass(BazelToolchainType.class) .ancestors(BaseRuleClasses.BaseRule.class) .build(); diff --git a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcToolchainSelectionTest.java b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcToolchainSelectionTest.java index f5f22a229b..e0d92a4c1e 100644 --- a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcToolchainSelectionTest.java +++ b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcToolchainSelectionTest.java @@ -55,7 +55,7 @@ public class CcToolchainSelectionTest extends BuildViewTestCase { } private static final String CPP_TOOLCHAIN_TYPE = - TestConstants.TOOLS_REPOSITORY + "//tools/cpp:toolchain_category"; + TestConstants.TOOLS_REPOSITORY + "//tools/cpp:toolchain_type"; @Test public void testResolvedCcToolchain() throws Exception { |