1 files changed, 206 insertions, 0 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/packages/OutputFileTest.java b/src/test/java/com/google/devtools/build/lib/packages/OutputFileTest.java
new file mode 100644
index 0000000000..1e26e8aeb2
--- /dev/null
+++ b/src/test/java/com/google/devtools/build/lib/packages/OutputFileTest.java
@@ -0,0 +1,206 @@
+// Copyright 2015 The Bazel Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package com.google.devtools.build.lib.packages;
+
+import com.google.devtools.build.lib.cmdline.PackageIdentifier;
+import com.google.devtools.build.lib.packages.util.PackageLoadingTestCase;
+import com.google.devtools.build.lib.testutil.TestRuleClassProvider;
+import com.google.devtools.build.lib.vfs.Path;
+
+public class OutputFileTest extends PackageLoadingTestCase {
+
+  private PackageFactory packageFactory;
+  private Package pkg;
+  private Rule rule;
+
+  @Override
+  protected void setUp() throws Exception {
+    super.setUp();
+    packageFactory = new PackageFactory(TestRuleClassProvider.getRuleClassProvider());
+
+    Path buildfile =
+        scratch.file(
+            "pkg/BUILD",
+            "genrule(name='foo', ",
+            "        srcs=[], ",
+            "        cmd='', ",
+            "        outs=['x', 'subdir/y'])");
+    this.pkg =
+        packageFactory.createPackageForTesting(
+            PackageIdentifier.createInDefaultRepo("pkg"), buildfile, getPackageManager(), reporter);
+    assertNoEvents();
+
+    this.rule = (Rule) pkg.getTarget("foo");
+  }
+
+  private void checkTargetRetainsGeneratingRule(OutputFile output) throws Exception {
+    assertSame(rule, output.getGeneratingRule());
+  }
+
+  private void checkName(OutputFile output, String expectedName) throws Exception {
+    assertEquals(expectedName, output.getName());
+  }
+
+  private void checkLabel(OutputFile output, String expectedLabelString) throws Exception {
+    assertEquals(expectedLabelString, output.getLabel().toString());
+  }
+
+  public void testGetAssociatedRule() throws Exception {
+    assertSame(rule, pkg.getTarget("x").getAssociatedRule());
+  }
+
+  public void testOutputFileInPackageDir() throws Exception {
+    OutputFile outputFileX = (OutputFile) pkg.getTarget("x");
+    checkTargetRetainsGeneratingRule(outputFileX);
+    checkName(outputFileX, "x");
+    checkLabel(outputFileX, "//pkg:x");
+    assertEquals("generated file", outputFileX.getTargetKind());
+  }
+
+  public void testOutputFileInSubdirectory() throws Exception {
+    OutputFile outputFileY = (OutputFile) pkg.getTarget("subdir/y");
+    checkTargetRetainsGeneratingRule(outputFileY);
+    checkName(outputFileY, "subdir/y");
+    checkLabel(outputFileY, "//pkg:subdir/y");
+  }
+
+  public void testEquivalenceRelation() throws Exception {
+    OutputFile outputFileX1 = (OutputFile) pkg.getTarget("x");
+    OutputFile outputFileX2 = (OutputFile) pkg.getTarget("x");
+    OutputFile outputFileY1 = (OutputFile) pkg.getTarget("subdir/y");
+    OutputFile outputFileY2 = (OutputFile) pkg.getTarget("subdir/y");
+    assertSame(outputFileX1, outputFileX2);
+    assertSame(outputFileY1, outputFileY2);
+    assertEquals(outputFileX1, outputFileX2);
+    assertEquals(outputFileX2, outputFileX1);
+    assertEquals(outputFileY1, outputFileY2);
+    assertEquals(outputFileY2, outputFileY1);
+    assertFalse(outputFileX1.equals(outputFileY1));
+    assertFalse(outputFileY1.equals(outputFileX1));
+    assertEquals(outputFileX1.hashCode(), outputFileX2.hashCode());
+    assertEquals(outputFileY1.hashCode(), outputFileY2.hashCode());
+  }
+
+  public void testDuplicateOutputFilesInDifferentRules() throws Exception {
+    Path buildfile =
+        scratch.file(
+            "two_outs/BUILD",
+            "genrule(name='a',",
+            "        cmd='ls >$(location out)',",
+            "        outs=['out'])",
+            "",
+            "genrule(name='b',",
+            "        cmd='ls >$(location out)',",
+            "        outs=['out'])");
+
+    reporter.removeHandler(failFastHandler);
+    packageFactory.createPackageForTesting(
+        PackageIdentifier.createInDefaultRepo("two_outs"),
+        buildfile,
+        getPackageManager(),
+        reporter);
+    assertContainsEvent(
+        "generated file 'out' in rule 'b' conflicts with "
+            + "existing generated file from rule 'a'");
+  }
+
+  public void testOutputFileNameConflictsWithExistingRule() throws Exception {
+    Path buildfile =
+        scratch.file(
+            "out_is_rule/BUILD",
+            "genrule(name='a',",
+            "        cmd='ls >$(location out)',",
+            "        outs=['out'])",
+            "",
+            "genrule(name='b',",
+            "        cmd='ls >$(location out)',",
+            "        outs=['a'])");
+
+    reporter.removeHandler(failFastHandler);
+    packageFactory.createPackageForTesting(
+        PackageIdentifier.createInDefaultRepo("out_is_rule"),
+        buildfile,
+        getPackageManager(),
+        reporter);
+    assertContainsEvent("generated file 'a' in rule 'b' conflicts with existing genrule rule");
+  }
+
+  public void testDuplicateOutputFilesInSameRule() throws Exception {
+    Path buildfile =
+        scratch.file(
+            "two_outs/BUILD",
+            "genrule(name='a',",
+            "        cmd='ls >$(location out)',",
+            "        outs=['out', 'out'])");
+
+    reporter.removeHandler(failFastHandler);
+    packageFactory.createPackageForTesting(
+        PackageIdentifier.createInDefaultRepo("two_outs"),
+        buildfile,
+        getPackageManager(),
+        reporter);
+    assertContainsEvent(
+        "generated file 'out' in rule 'a' conflicts with "
+            + "existing generated file from rule 'a'");
+  }
+
+  public void testOutputFileWithIllegalName() throws Exception {
+    Path buildfile =
+        scratch.file(
+            "bad_out_name/BUILD",
+            "genrule(name='a',",
+            "        cmd='ls',",
+            "        outs=['!@#'])");
+
+    reporter.removeHandler(failFastHandler);
+    packageFactory.createPackageForTesting(
+        PackageIdentifier.createInDefaultRepo("bad_out_name"),
+        buildfile,
+        getPackageManager(),
+        reporter);
+    assertContainsEvent("illegal output file name '!@#' in rule //bad_out_name:a");
+  }
+
+  public void testOutputFileWithCrossPackageLabel() throws Exception {
+    Path buildfile =
+        scratch.file(
+            "cross_package_out/BUILD",
+            "genrule(name='a',",
+            "        cmd='ls',",
+            "        outs=['//foo:bar'])");
+
+    reporter.removeHandler(failFastHandler);
+    packageFactory.createPackageForTesting(
+        PackageIdentifier.createInDefaultRepo("cross_package_out"),
+        buildfile,
+        getPackageManager(),
+        reporter);
+    assertContainsEvent("label '//foo:bar' is not in the current package");
+  }
+
+  public void testOutputFileNamedBUILD() throws Exception {
+    Path buildfile =
+        scratch.file(
+            "output_called_build/BUILD",
+            "genrule(name='a',",
+            "        cmd='ls',",
+            "        outs=['BUILD'])");
+
+    reporter.removeHandler(failFastHandler);
+    packageFactory.createPackageForTesting(
+        PackageIdentifier.createInDefaultRepo("output_called_build"), buildfile,
+        getPackageManager(), reporter);
+    assertContainsEvent("generated file 'BUILD' in rule 'a' conflicts with existing source file");
+  }
+}