diff options
Diffstat (limited to 'src/test/java/com/google/devtools/build/lib/analysis/util')
4 files changed, 17 insertions, 26 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestCase.java b/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestCase.java index ff655baad9..5c88265159 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestCase.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestCase.java @@ -286,7 +286,7 @@ public abstract class AnalysisTestCase extends FoundationTestCase { throws InterruptedException { BuildConfiguration targetConfig = Iterables.getOnlyElement(masterConfig.getTargetConfigurations()); - if (useDynamicVersionIfEnabled && targetConfig.useDynamicConfigurations()) { + if (useDynamicVersionIfEnabled) { return skyframeExecutor.getConfigurationForTesting( reporter, targetConfig.fragmentClasses(), targetConfig.getOptions()); } else { diff --git a/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestUtil.java b/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestUtil.java index e04eae3c67..7e2400da9a 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestUtil.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestUtil.java @@ -432,20 +432,17 @@ public final class AnalysisTestUtil { hostConfiguration.getMiddlemanDirectory(RepositoryName.MAIN).getPath().toString(), "internal(host)"); - if (targetConfiguration.useDynamicConfigurations()) { - // With dynamic configurations, the output paths that bin, genfiles, etc. refer to may - // or may not include the C++-contributed pieces. e.g. they may be - // bazel-out/gcc-X-glibc-Y-k8-fastbuild/ or they may be bazel-out/fastbuild/. This code - // adds support for the non-C++ case, too. - Map<String, String> prunedRootMap = new HashMap<>(); - for (Map.Entry<String, String> root : rootMap.entrySet()) { - prunedRootMap.put( - OUTPUT_PATH_CPP_PREFIX_PATTERN.matcher(root.getKey()).replaceFirst(""), - root.getValue() - ); - } - rootMap.putAll(prunedRootMap); - } + // The output paths that bin, genfiles, etc. refer to may or may not include the C++-contributed + // pieces. e.g. they may be bazel-out/gcc-X-glibc-Y-k8-fastbuild/ or they may be + // bazel-out/fastbuild/. This code adds support for the non-C++ case, too. + Map<String, String> prunedRootMap = new HashMap<>(); + for (Map.Entry<String, String> root : rootMap.entrySet()) { + prunedRootMap.put( + OUTPUT_PATH_CPP_PREFIX_PATTERN.matcher(root.getKey()).replaceFirst(""), + root.getValue() + ); + } + rootMap.putAll(prunedRootMap); Set<String> files = new LinkedHashSet<>(); for (Artifact artifact : artifacts) { diff --git a/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java b/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java index 1f0a7a4e99..c00b06e08f 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java @@ -1304,16 +1304,12 @@ public abstract class BuildViewTestCase extends FoundationTestCase { BuildConfiguration config; try { config = getConfiguredTarget(label).getConfiguration(); + config = view.getDynamicConfigurationForTesting(getTarget(label), config, reporter); } catch (LabelSyntaxException e) { throw new IllegalArgumentException(e); - } - if (targetConfig.useDynamicConfigurations()) { - try { - config = view.getDynamicConfigurationForTesting(getTarget(label), config, reporter); - } catch (Exception e) { - //TODO(b/36585204): Clean this up - throw new RuntimeException(e); - } + } catch (Exception e) { + //TODO(b/36585204): Clean this up + throw new RuntimeException(e); } return new ConfiguredTargetKey(makeLabel(label), config); } diff --git a/src/test/java/com/google/devtools/build/lib/analysis/util/ConfigurationTestCase.java b/src/test/java/com/google/devtools/build/lib/analysis/util/ConfigurationTestCase.java index f01405e538..c2c4c30138 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/util/ConfigurationTestCase.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/util/ConfigurationTestCase.java @@ -56,7 +56,6 @@ import com.google.devtools.common.options.OptionEffectTag; import com.google.devtools.common.options.Options; import com.google.devtools.common.options.OptionsBase; import com.google.devtools.common.options.OptionsParser; -import java.util.Collection; import java.util.HashMap; import java.util.List; import java.util.Map; @@ -196,9 +195,8 @@ public abstract class ConfigurationTestCase extends FoundationTestCase { public void assertConfigurationsHaveUniqueOutputDirectories( BuildConfigurationCollection configCollection) throws Exception { - Collection<BuildConfiguration> allConfigs = configCollection.getAllConfigurations(); Map<Root, BuildConfiguration> outputPaths = new HashMap<>(); - for (BuildConfiguration config : allConfigs) { + for (BuildConfiguration config : configCollection.getTargetConfigurations()) { if (config.isActionsEnabled()) { BuildConfiguration otherConfig = outputPaths.get( config.getOutputDirectory(RepositoryName.MAIN)); |