diff options
Diffstat (limited to 'src/main/java')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/syntax/Printer.java | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/syntax/Printer.java b/src/main/java/com/google/devtools/build/lib/syntax/Printer.java index 3a6c60d7e0..b91237ad72 100644 --- a/src/main/java/com/google/devtools/build/lib/syntax/Printer.java +++ b/src/main/java/com/google/devtools/build/lib/syntax/Printer.java @@ -387,8 +387,10 @@ public class Printer { this.append(o.toString()); } else { - // TODO(bazel-team): change to a special representation for unknown objects - this.append(o.toString()); + // Other types of objects shouldn't be leaked to Skylark, but if happens, their + // .toString method shouldn't be used because their return values are likely to contain + // memory addresses or other nondeterministic information. + this.append("<unknown object " + o.getClass().getName() + ">"); } return this; |