diff options
Diffstat (limited to 'src/main/java/com/google')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/collect/nestedset/NestedSetVisitor.java | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/collect/nestedset/NestedSetVisitor.java b/src/main/java/com/google/devtools/build/lib/collect/nestedset/NestedSetVisitor.java index c66ef27662..090b8e33bb 100644 --- a/src/main/java/com/google/devtools/build/lib/collect/nestedset/NestedSetVisitor.java +++ b/src/main/java/com/google/devtools/build/lib/collect/nestedset/NestedSetVisitor.java @@ -85,7 +85,10 @@ public final class NestedSetVisitor<E> { } private boolean add(Object node) { - return seenNodes.add(node); + // Though it may look redundant, the contains call is much cheaper than the add and can + // greatly improve the performance and reduce the contention associated with checking + // seenNodes. + return !seenNodes.contains(node) && seenNodes.add(node); } } } |