aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java
diff options
context:
space:
mode:
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java9
1 files changed, 6 insertions, 3 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java
index d7eda03665..bfc7fb3453 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java
@@ -316,7 +316,8 @@ public abstract class SkyframeExecutor implements WalkableGraphFactory {
Root buildDataDirectory,
PackageFactory pkgFactory,
Predicate<PathFragment> allowedMissingInputs) {
- RuleClassProvider ruleClassProvider = pkgFactory.getRuleClassProvider();
+ ConfiguredRuleClassProvider ruleClassProvider =
+ (ConfiguredRuleClassProvider) pkgFactory.getRuleClassProvider();
// We use an immutable map builder for the nice side effect that it throws if a duplicate key
// is inserted.
ImmutableMap.Builder<SkyFunctionName, SkyFunction> map = ImmutableMap.builder();
@@ -1632,8 +1633,10 @@ public abstract class SkyframeExecutor implements WalkableGraphFactory {
return new CyclesReporter(
new TransitiveTargetCycleReporter(packageManager),
new ActionArtifactCycleReporter(packageManager),
- new SkylarkModuleCycleReporter(),
- new ConfiguredTargetCycleReporter(packageManager));
+ // TODO(ulfjack): The SkylarkModuleCycleReporter swallows previously reported cycles
+ // unconditionally! Is that intentional?
+ new ConfiguredTargetCycleReporter(packageManager),
+ new SkylarkModuleCycleReporter());
}
CyclesReporter getCyclesReporter() {