diff options
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/ConfigurationCollectionFunction.java')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/skyframe/ConfigurationCollectionFunction.java | 23 |
1 files changed, 12 insertions, 11 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/ConfigurationCollectionFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/ConfigurationCollectionFunction.java index d50e2a65d1..e73b2b4cd5 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/ConfigurationCollectionFunction.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/ConfigurationCollectionFunction.java @@ -33,10 +33,8 @@ import com.google.devtools.build.skyframe.SkyFunction; import com.google.devtools.build.skyframe.SkyFunctionException; import com.google.devtools.build.skyframe.SkyKey; import com.google.devtools.build.skyframe.SkyValue; - import java.util.ArrayList; import java.util.List; - import javax.annotation.Nullable; /** @@ -75,10 +73,12 @@ public class ConfigurationCollectionFunction implements SkyFunction { } /** Create the build configurations with the given options. */ - private BuildConfigurationCollection getConfigurations(Environment env, - PackageProviderForConfigurations loadedPackageProvider, BuildOptions buildOptions, + private BuildConfigurationCollection getConfigurations( + Environment env, + PackageProviderForConfigurations loadedPackageProvider, + BuildOptions buildOptions, ImmutableSet<String> multiCpu) - throws InvalidConfigurationException { + throws InvalidConfigurationException, InterruptedException { // We cache all the related configurations for this target configuration in a cache that is // dropped at the end of this method call. We instead rely on the cache for entire collections // for caching the target and related configurations, and on a dedicated host configuration @@ -115,11 +115,10 @@ public class ConfigurationCollectionFunction implements SkyFunction { return new BuildConfigurationCollection(targetConfigurations, hostConfiguration); } - /** - * Returns the host configuration, or null on missing Skyframe deps. - */ - private BuildConfiguration getHostConfiguration(Environment env, - BuildConfiguration targetConfiguration) throws InvalidConfigurationException { + /** Returns the host configuration, or null on missing Skyframe deps. */ + private static BuildConfiguration getHostConfiguration( + Environment env, BuildConfiguration targetConfiguration) + throws InvalidConfigurationException, InterruptedException { if (targetConfiguration.useDynamicConfigurations()) { BuildOptions hostOptions = HostTransition.INSTANCE.apply(targetConfiguration.getOptions()); SkyKey hostConfigKey = @@ -149,7 +148,9 @@ public class ConfigurationCollectionFunction implements SkyFunction { Cache<String, BuildConfiguration> cache, EventHandler originalEventListener, PackageProviderForConfigurations loadedPackageProvider, - BuildOptions buildOptions, String cpuOverride) throws InvalidConfigurationException { + BuildOptions buildOptions, + String cpuOverride) + throws InvalidConfigurationException, InterruptedException { ErrorSensingEventHandler eventHandler = new ErrorSensingEventHandler(originalEventListener); if (cpuOverride != null) { // TODO(bazel-team): Options classes should be immutable. This is a bit of a hack. |