diff options
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules/extra')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/rules/extra/ExtraAction.java | 8 | ||||
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/rules/extra/ExtraActionSpec.java | 7 |
2 files changed, 4 insertions, 11 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/extra/ExtraAction.java b/src/main/java/com/google/devtools/build/lib/rules/extra/ExtraAction.java index a947232147..9a0c33886f 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/extra/ExtraAction.java +++ b/src/main/java/com/google/devtools/build/lib/rules/extra/ExtraAction.java @@ -21,6 +21,7 @@ import com.google.common.collect.ImmutableSet; import com.google.common.collect.Sets; import com.google.devtools.build.lib.actions.AbstractAction; import com.google.devtools.build.lib.actions.Action; +import com.google.devtools.build.lib.actions.ActionEnvironment; import com.google.devtools.build.lib.actions.ActionExecutionContext; import com.google.devtools.build.lib.actions.ActionExecutionException; import com.google.devtools.build.lib.actions.Artifact; @@ -39,7 +40,6 @@ import com.google.devtools.build.lib.vfs.FileSystemUtils; import java.io.IOException; import java.util.Collection; import java.util.Map; -import java.util.Set; import javax.annotation.Nullable; /** @@ -72,8 +72,7 @@ public final class ExtraAction extends SpawnAction { Action shadowedAction, boolean createDummyOutput, CommandLine argv, - Map<String, String> environment, - Set<String> clientEnvironmentVariables, + ActionEnvironment env, Map<String, String> executionInfo, String progressMessage, String mnemonic) { @@ -89,8 +88,7 @@ public final class ExtraAction extends SpawnAction { AbstractAction.DEFAULT_RESOURCE_SET, argv, false, - ImmutableMap.copyOf(environment), - ImmutableSet.copyOf(clientEnvironmentVariables), + env, ImmutableMap.copyOf(executionInfo), progressMessage, // TODO(michajlo): Do we need the runfiles manifest as an input / should this be composite? diff --git a/src/main/java/com/google/devtools/build/lib/rules/extra/ExtraActionSpec.java b/src/main/java/com/google/devtools/build/lib/rules/extra/ExtraActionSpec.java index 65a81d91ee..3ccda08af2 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/extra/ExtraActionSpec.java +++ b/src/main/java/com/google/devtools/build/lib/rules/extra/ExtraActionSpec.java @@ -37,7 +37,6 @@ import java.util.Collection; import java.util.LinkedHashSet; import java.util.List; import java.util.Map; -import java.util.Set; /** * The specification for a particular extra action type. @@ -120,9 +119,6 @@ public final class ExtraActionSpec implements TransitiveInfoProvider { // See {@link #createExpandedCommand} for list of supported variables. String command = createExpandedCommand(owningRule, actionToShadow, extraActionInfoFile); - Map<String, String> env = owningRule.getConfiguration().getLocalShellEnvironment(); - Set<String> clientEnvVars = owningRule.getConfiguration().getVariableShellEnvironment(); - CommandHelper commandHelper = new CommandHelper( owningRule, @@ -145,8 +141,7 @@ public final class ExtraActionSpec implements TransitiveInfoProvider { actionToShadow, createDummyOutput, CommandLine.of(argv), - env, - clientEnvVars, + owningRule.getConfiguration().getActionEnvironment(), executionInfo, commandMessage, label.getName())); |