aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/rules/apple/XcodeConfig.java
diff options
context:
space:
mode:
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules/apple/XcodeConfig.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/rules/apple/XcodeConfig.java131
1 files changed, 15 insertions, 116 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/apple/XcodeConfig.java b/src/main/java/com/google/devtools/build/lib/rules/apple/XcodeConfig.java
index 7444c45bc0..1b6e998d3c 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/apple/XcodeConfig.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/apple/XcodeConfig.java
@@ -15,79 +15,25 @@
package com.google.devtools.build.lib.rules.apple;
import com.google.common.base.Joiner;
-import com.google.common.base.Preconditions;
import com.google.common.base.Strings;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.Iterables;
import com.google.common.collect.Maps;
import com.google.devtools.build.lib.analysis.ConfiguredTarget;
-import com.google.devtools.build.lib.analysis.RedirectChaser;
import com.google.devtools.build.lib.analysis.RuleConfiguredTargetBuilder;
import com.google.devtools.build.lib.analysis.RuleConfiguredTargetFactory;
import com.google.devtools.build.lib.analysis.RuleContext;
import com.google.devtools.build.lib.analysis.RunfilesProvider;
-import com.google.devtools.build.lib.analysis.config.ConfigurationEnvironment;
-import com.google.devtools.build.lib.analysis.config.InvalidConfigurationException;
import com.google.devtools.build.lib.analysis.configuredtargets.RuleConfiguredTarget;
import com.google.devtools.build.lib.cmdline.Label;
-import com.google.devtools.build.lib.events.Event;
-import com.google.devtools.build.lib.packages.BuildType;
-import com.google.devtools.build.lib.packages.NoSuchPackageException;
-import com.google.devtools.build.lib.packages.NoSuchTargetException;
-import com.google.devtools.build.lib.packages.NonconfigurableAttributeMapper;
-import com.google.devtools.build.lib.packages.Rule;
-import com.google.devtools.build.lib.packages.Target;
-import java.util.List;
+import com.google.devtools.build.lib.rules.apple.AppleCommandLineOptions.AppleBitcodeMode;
import java.util.Map;
-import javax.annotation.Nullable;
/**
* Implementation for the {@code xcode_config} rule.
*/
public class XcodeConfig implements RuleConfiguredTargetFactory {
-
- private static ImmutableList<XcodeVersionRuleData> getAvailableVersions(
- ConfigurationEnvironment env, Rule xcodeConfigTarget)
- throws InvalidConfigurationException, InterruptedException {
- List<Label> xcodeVersionLabels = NonconfigurableAttributeMapper.of(xcodeConfigTarget)
- .get(XcodeConfigRule.VERSIONS_ATTR_NAME, BuildType.LABEL_LIST);
- ImmutableList.Builder<XcodeVersionRuleData> xcodeVersionRuleListBuilder =
- ImmutableList.builder();
- for (Label label : xcodeVersionLabels) {
- Rule xcodeVersionRule = getRuleForLabel(label, "xcode_version", env, "xcode_version");
- xcodeVersionRuleListBuilder.add(new XcodeVersionRuleData(label, xcodeVersionRule));
- }
- return xcodeVersionRuleListBuilder.build();
- }
-
- /**
- * Uses the {@link AppleCommandLineOptions#xcodeVersion} and {@link
- * AppleCommandLineOptions#xcodeVersionConfig} command line options to determine and return the
- * effective xcode version properties. Returns absent if no explicit xcode version is declared,
- * and host system defaults should be used.
- *
- * @param env the current configuration environment
- * @param appleOptions the command line options
- * @throws InvalidConfigurationException if the options given (or configuration targets) were
- * malformed and thus the xcode version could not be determined
- */
- static XcodeVersionProperties getXcodeVersionProperties(
- ConfigurationEnvironment env, AppleCommandLineOptions appleOptions)
- throws InvalidConfigurationException, InterruptedException {
- Label xcodeVersionConfigLabel = appleOptions.xcodeVersionConfig;
-
- Rule xcodeConfigRule = getRuleForLabel(
- xcodeVersionConfigLabel, "xcode_config", env, "xcode_version_config");
-
- ImmutableList<XcodeVersionRuleData> versions = getAvailableVersions(env, xcodeConfigRule);
- XcodeVersionRuleData defaultVersion = getDefaultVersion(env, xcodeConfigRule);
-
- try {
- return resolveXcodeVersion(appleOptions.xcodeVersion, versions, defaultVersion);
- } catch (XcodeConfigException e) {
- throw new InvalidConfigurationException(e.getMessage());
- }
- }
+ private static final DottedVersion MINIMUM_BITCODE_XCODE_VERSION = DottedVersion.fromString("7");
/**
* An exception that signals that an Xcode config setup was invalid.
@@ -102,8 +48,8 @@ public class XcodeConfig implements RuleConfiguredTargetFactory {
@Override
public ConfiguredTarget create(RuleContext ruleContext)
throws InterruptedException, RuleErrorException {
- AppleCommandLineOptions appleOptions =
- ruleContext.getFragment(AppleConfiguration.class).getOptions();
+ AppleConfiguration appleConfig = ruleContext.getFragment(AppleConfiguration.class);
+ AppleCommandLineOptions appleOptions = appleConfig.getOptions();
XcodeVersionRuleData defaultVersion = ruleContext.getPrerequisite(
XcodeConfigRule.DEFAULT_ATTR_NAME, RuleConfiguredTarget.Mode.TARGET,
XcodeVersionRuleData.class);
@@ -145,6 +91,16 @@ public class XcodeConfig implements RuleConfiguredTargetFactory {
macosSdkVersion, macosMinimumOsVersion,
xcodeVersionProperties.getXcodeVersion().orNull());
+ AppleBitcodeMode bitcodeMode = appleConfig.getBitcodeMode();
+ DottedVersion xcodeVersion = xcodeVersions.getXcodeVersion();
+ if (bitcodeMode != AppleBitcodeMode.NONE
+ && xcodeVersion != null
+ && xcodeVersion.compareTo(MINIMUM_BITCODE_XCODE_VERSION) < 0) {
+ ruleContext.throwWithRuleError(String.format(
+ "apple_bitcode mode '%s' is unsupported for xcode version '%s'",
+ bitcodeMode, xcodeVersion));
+ }
+
return new RuleConfiguredTargetBuilder(ruleContext)
.addProvider(RunfilesProvider.class, RunfilesProvider.EMPTY)
.addNativeDeclaredProvider(xcodeVersions)
@@ -226,25 +182,6 @@ public class XcodeConfig implements RuleConfiguredTargetFactory {
}
/**
- * Returns the default xcode version to use, if no {@code --xcode_version} command line flag was
- * specified.
- */
- @Nullable
- private static XcodeVersionRuleData getDefaultVersion(
- ConfigurationEnvironment env, Rule xcodeConfigTarget)
- throws InvalidConfigurationException, InterruptedException {
- Label defaultVersionLabel = NonconfigurableAttributeMapper.of(xcodeConfigTarget)
- .get(XcodeConfigRule.DEFAULT_ATTR_NAME, BuildType.LABEL);
- if (defaultVersionLabel != null) {
- Rule defaultVersionRule = getRuleForLabel(
- defaultVersionLabel, "xcode_version", env, "default xcode version");
- return new XcodeVersionRuleData(defaultVersionLabel, defaultVersionRule);
- } else {
- return null;
- }
- }
-
- /**
* Returns a map where keys are "names" of xcode versions as defined by the configuration target,
* and values are the rule data objects which contain information regarding that xcode version.
*
@@ -294,54 +231,16 @@ public class XcodeConfig implements RuleConfiguredTargetFactory {
}
/**
- * If the given label (following redirects) is a target for a rule of type {@code type}, then
- * returns the {@link Rule} representing that target. Otherwise, throws a {@link
- * InvalidConfigurationException}.
- */
- static Rule getRuleForLabel(
- Label label, String type, ConfigurationEnvironment env, String description)
- throws InvalidConfigurationException, InterruptedException {
- label = RedirectChaser.followRedirects(env, label, description);
-
- if (label == null) {
- throw new InvalidConfigurationException(String.format(
- "Expected value of %s (%s) to resolve to a target of type %s",
- description, label, type));
- }
-
- try {
- Target target = env.getTarget(label);
-
- if (target instanceof Rule && ((Rule) target).getRuleClass().equals(type)) {
- return (Rule) target;
- } else {
- throw new InvalidConfigurationException(String.format(
- "Expected value of %s (%s) to resolve to a target of type %s",
- description, label, type));
- }
- } catch (NoSuchPackageException | NoSuchTargetException exception) {
- env.getEventHandler().handle(Event.error(exception.getMessage()));
- throw new InvalidConfigurationException(exception);
- }
- }
-
- /**
* Returns the minimum compatible OS version for target simulator and devices for a particular
* platform type.
*/
public static DottedVersion getMinimumOsForPlatformType(
RuleContext ruleContext, ApplePlatform.PlatformType platformType) {
- AppleConfiguration config = ruleContext.getFragment(AppleConfiguration.class);
XcodeConfigProvider versions = ruleContext.getPrerequisite(
XcodeConfigRule.XCODE_CONFIG_ATTR_NAME,
RuleConfiguredTarget.Mode.TARGET,
XcodeConfigProvider.PROVIDER);
- DottedVersion fromProvider = versions.getMinimumOsForPlatformType(platformType);
- DottedVersion fromConfig = config.getMinimumOsForPlatformType(platformType);
- // This sanity check is there to keep this provider in sync with AppleConfiguration until the
- // latter can be removed. Tracking bug: https://github.com/bazelbuild/bazel/issues/3424
- Preconditions.checkState(fromProvider.equals(fromConfig));
- return fromProvider;
+ return versions.getMinimumOsForPlatformType(platformType);
}
/**
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-27 21:17:52 +0000