diff options
| author |  gregce <gregce@google.com> | 2017-05-03 22:58:50 +0200 |
|---|---|---|
| committer |  Damien Martin-Guillerez <dmarting@google.com> | 2017-05-04 13:13:54 +0200 |
| commit | d746655be6a46ac05252cf460dfed14d1f7ca120 (patch) | |
| tree | 46f2e7da93f68844b1e92b58bb0072f67b9712ee /tools | |
| parent | 5f1d88646b35625aa90a178efb8ef8ca4b736a00 (diff) | |
BuildOptions cleanup:
1) Remove obsolete originalOptions field. This was originally added to
support "parent" transitions, which supported config1 -> config2 -> config1
transitions by having config2 store config1's options.
The purpose of this feature was to support LIPO (which has a DATA -> TARGET
transition). But https://github.com/bazelbuild/bazel/commit/ff29c0b39cf936a2699b05edd54f483f1a037d93
makes this unnecessary.
2) Support the "disable actions" feature of the LIPO context collector configuration.
Putting this in BuildOptions make this dynamic config-compatible.
This change intentionally doesn't add disableOptions to BuildOptions.equals() or
BuildOptions.hashCode(). It'd be great to do that. But that has semantic consequences.
And we've run into really tricky bugs in the past with dynamic configurations and
BuildOptions.equals / BuildConfiguration.equals. So it's best to experiment with
that in its own change.
PiperOrigin-RevId: 154999718
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions