aboutsummaryrefslogtreecommitdiffhomepage
path: root/tools
diff options
context:
space:
mode:
authorGravatar buchgr <buchgr@google.com>2018-08-09 01:18:53 -0700
committerGravatar Copybara-Service <copybara-piper@google.com>2018-08-09 01:20:22 -0700
commitd215b64362c4ede61c8ba87b5f3f57bce4785d15 (patch)
tree25135ba68fbe5e6eeede7a13345c1f881cee4a69 /tools
parent4e3a64df1b7f923c61f443098d3f06e4be993a4f (diff)
Fix StackOverflowError on Windows. Fixes #5730
We found that with JDK9 and up Bazel would sometimes crash with a StackOverflowError in one of the Command-Accumulator-Thread-* threads. We experimentally found that this error was due to these threads being constrained to a 32KiB stack size. The default stack size for JVM threads on most 64-bit systems is 1MiB (So that's 3% of the default). The purpose of the Command-Accumulator-Threads is to read stdout/stderr from processes that Bazel launches locally. The proposed fix is to just use the system default stack size for these threads. The alternative is to increase the size limit to some arbitrary number that happens to work, but this is likely premature optimization and I'd like to avoid that if possible. We further found that this code even predates Blaze/Bazel and is from 2005. PiperOrigin-RevId: 208009940
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions