diff options
| author |  brendandouglas <brendandouglas@google.com> | 2018-06-21 08:57:19 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-06-21 08:58:30 -0700 |
| commit | 62f5bdc9074bbe4a6a85ff6bf4bdb313950e938c (patch) | |
| tree | 9ec2cc33bb2b9dd0d150ebd6dcf31d1e17b0d1cb /tools | |
| parent | 2b945323d2b4cf7dfdf988b9b04c4fb75e416206 (diff) | |
Skylark debugging protocol: only track paused or stepping threads.
- remove blaze-side thread creation/destruction hooks
- remove ListThreads, ThreadStarted, ThreadEnded events from protocol
- don't track unpaused, not stepping threads in ThreadHandler
The threading model didn't provide useful information -- in practice,
users never want to list currently-running threads, and the debug
client doesn't need to list currently-paused threads, since it receives
each ThreadPaused and ThreadContinued event, so its model is always up to date.
Not tracking thread creation/destruction greatly simplifies the API, and
reduces the blaze-side hooks -- it was also only semi-implemented, as
plenty (/most?) skylark threads were never registered.
The biggest cost to removing this is lack of nice thread names. In
practice, I think the benefits greatly outweigh this cost. If it ever
becomes a problem, there are other lighter-weight ways of communicating
thread names.
TAG_CHANGE_OK=This proto has never yet been used
TYPE_CHANGE_OK=This proto has never yet been used
PiperOrigin-RevId: 201532462
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions