diff options
| author |  Googler <noreply@google.com> | 2016-10-12 15:44:25 +0000 |
|---|---|---|
| committer |  Yun Peng <pcloudy@google.com> | 2016-10-12 17:12:42 +0000 |
| commit | 368d7b73701ada39e3373c954130e4c6de170377 (patch) | |
| tree | afd42989ce884827406cbee286f6f5614553c152 /tools | |
| parent | beb00ebf7fb5223750011568019dbf80a0f3e8c5 (diff) | |
Prevent empty swift_library srcs.
* This produces more human-readable error messages in cases where sources are omitted (e.g. if a glob matches nothing).
--
MOS_MIGRATED_REVID=135920885
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/build_defs/apple/swift.bzl | 2 | ||||
| -rw-r--r-- | tools/build_defs/apple/test/apple_rule_test.bzl | 3 |
2 files changed, 3 insertions, 2 deletions
diff --git a/tools/build_defs/apple/swift.bzl b/tools/build_defs/apple/swift.bzl index 6c9289a466..bfd5952481 100644 --- a/tools/build_defs/apple/swift.bzl +++ b/tools/build_defs/apple/swift.bzl @@ -335,7 +335,7 @@ def _swift_library_impl(ctx): swift_library = rule( _swift_library_impl, attrs = { - "srcs": attr.label_list(allow_files = [".swift"]), + "srcs": attr.label_list(allow_files = [".swift"], allow_empty=False), "deps": attr.label_list(providers=[["swift"], ["objc"]]), "module_name": attr.string(mandatory=False), "defines": attr.string_list(mandatory=False, allow_empty=True), diff --git a/tools/build_defs/apple/test/apple_rule_test.bzl b/tools/build_defs/apple/test/apple_rule_test.bzl index 57c8dcebee..db0f345774 100644 --- a/tools/build_defs/apple/test/apple_rule_test.bzl +++ b/tools/build_defs/apple/test/apple_rule_test.bzl @@ -28,7 +28,8 @@ def apple_rule_test(): """Issue simple tests on apple rules.""" swift_library( name = "test_lib", - module_name = "test_lib" + module_name = "test_lib", + srcs = ["source.swift"] ) rule_test( |