diff options
| author |  Marcel Hlopko <hlopko@google.com> | 2017-03-08 11:17:10 +0000 |
|---|---|---|
| committer |  Vladimir Moskva <vladmos@google.com> | 2017-03-08 13:55:40 +0000 |
| commit | 0e3757164a2f67414ac0ce7b3d84125ad6c01564 (patch) | |
| tree | 7a2f2cc266949a55a0a700ce8f4858c210a885fe /tools/cpp/cc_configure.bzl | |
| parent | a5ba0d3711e84ef47525d6b7fe1ca9871853c1a6 (diff) | |
Make gold autodetection more robust on macos
Some macos clang versions don't fail when setting -fuse-ld=gold, which makes
cc_configure.bzl think gold linker is available, when it is actually not.
The sideeffect of this cl is that we will not autodetect gold when only a very
old (year 2010 and older) is present. I assume this is fine.
Fixes #2502
--
PiperOrigin-RevId: 149521872
MOS_MIGRATED_REVID=149521872
Diffstat (limited to 'tools/cpp/cc_configure.bzl')
| -rw-r--r-- | tools/cpp/cc_configure.bzl | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/tools/cpp/cc_configure.bzl b/tools/cpp/cc_configure.bzl index 9437bea7fd..99ae959582 100644 --- a/tools/cpp/cc_configure.bzl +++ b/tools/cpp/cc_configure.bzl @@ -199,6 +199,11 @@ def _is_gold_supported(repository_ctx, cc): "-fuse-ld=gold", "-o", "/dev/null", + # Some macos clang versions don't fail when setting -fuse-ld=gold, adding + # these lines to force it to. This also means that we will not detect + # gold when only a very old (year 2010 and older) is present. + "-Wl,--start-lib", + "-Wl,--end-lib", str(repository_ctx.path("tools/cpp/empty.cc")) ]) return result.return_code == 0 |