diff options
| author |  Samer Masterson <samer@dropbox.com> | 2018-03-02 01:21:37 -0800 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-03-02 01:23:18 -0800 |
| commit | fefd1b24017ddb7606056bec081a173217a116c8 (patch) | |
| tree | 818fe2ae9856844eca467257fba76b1eb4c2a04e /tools/cpp/CROSSTOOL.tpl | |
| parent | 627c27698774c50987b2b8716fd8d46aa299c7ff (diff) | |
CROSSTOOLS: Fix comment for /EHsc compiler flag
The previous comment referred to the option `/EHa`, but `/EHsc` is the option to only catch C++ standards (which seems to be what we want, according to this doc: https://msdn.microsoft.com/en-us/library/1deeycx5.aspx)
Closes #4739.
PiperOrigin-RevId: 187593737
Diffstat (limited to 'tools/cpp/CROSSTOOL.tpl')
| -rw-r--r-- | tools/cpp/CROSSTOOL.tpl | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/tools/cpp/CROSSTOOL.tpl b/tools/cpp/CROSSTOOL.tpl index 57895e5621..dce98cd835 100644 --- a/tools/cpp/CROSSTOOL.tpl +++ b/tools/cpp/CROSSTOOL.tpl @@ -249,7 +249,8 @@ toolchain { compiler_flag: "/Gy" # Use string pooling. compiler_flag: "/GF" - # Catch both asynchronous (structured) and synchronous (C++) exceptions. + # Catch C++ exceptions only and tell the compiler to assume that functions declared + # as extern "C" never throw a C++ exception. compiler_flag: "/EHsc" # Globally disabled warnings. |