aboutsummaryrefslogtreecommitdiffhomepage
path: root/tools/build_defs/groovy
diff options
context:
space:
mode:
authorGravatar Erik Kuefler <ekuefler@gmail.com>2015-10-30 15:33:16 +0000
committerGravatar Florian Weikert <fwe@google.com>2015-11-02 16:52:40 +0000
commitc27dc1997f4f474f8533440c0ee4f2e19155af0e (patch)
treef74139aef8cfe474504028813067faa101f39887 /tools/build_defs/groovy
parentc7fd809d285e5400c3dbf1de7e57ec799a3e4c08 (diff)
Error out if no src files are provided to Groovy
Otherwise you get groovyc's usage message spammed to stdout -- Change-Id: I04bcfd9166adb6c9287839035f025f93d805e738 Reviewed-on: https://bazel-review.googlesource.com/#/c/2251/ MOS_MIGRATED_REVID=106693428
Diffstat (limited to 'tools/build_defs/groovy')
-rw-r--r--tools/build_defs/groovy/groovy.bzl5
1 files changed, 4 insertions, 1 deletions
diff --git a/tools/build_defs/groovy/groovy.bzl b/tools/build_defs/groovy/groovy.bzl
index b2c7947003..ddfdea6e28 100644
--- a/tools/build_defs/groovy/groovy.bzl
+++ b/tools/build_defs/groovy/groovy.bzl
@@ -79,7 +79,7 @@ _groovy_jar = rule(
implementation = _groovy_jar_impl,
attrs = {
"srcs": attr.label_list(
- mandatory=False,
+ non_empty=True,
allow_files=FileType([".groovy"])),
"deps": attr.label_list(
mandatory=False,
@@ -277,6 +277,9 @@ def spock_test(
"//external:spock",
]
+ if len(specs) == 0:
+ fail("Must provide at least one file in specs")
+
# Put all Java sources into a Java library
if java_srcs:
native.java_library(