aboutsummaryrefslogtreecommitdiffhomepage
path: root/third_party
diff options
context:
space:
mode:
authorGravatar Erik Kuefler <ekuefler@gmail.com>2015-09-03 09:02:12 +0000
committerGravatar Damien Martin-Guillerez <dmarting@google.com>2015-09-03 09:05:14 +0000
commitfde4509e926af53df20db000d380d8fae486b587 (patch)
treeab14eeed9312c31c376bb9eaa5c02361117a4400 /third_party
parentc010dc3d632a8ffd31619a7a2b88c00c3b4c6fb6 (diff)
Fix a signed vs unsigned comparison warning in the ijar zipper.
This is more than just a cosmetic issue. Since groovy and appengine rules depend directly on this target, the zipper gets built in the user's workspace whenever a groovy/appengine target is built. If the workspace is set to upgrade warnings to errors, this can cause builds to fail. -- Change-Id: I6c8b347df14098945c788411fc3e38f9c128596f Reviewed-on: https://bazel-review.googlesource.com/1951 MOS_MIGRATED_REVID=102223767
Diffstat (limited to 'third_party')
-rw-r--r--third_party/ijar/zip_main.cc4
1 files changed, 2 insertions, 2 deletions
diff --git a/third_party/ijar/zip_main.cc b/third_party/ijar/zip_main.cc
index 6c2a974397..43b035ad97 100644
--- a/third_party/ijar/zip_main.cc
+++ b/third_party/ijar/zip_main.cc
@@ -72,8 +72,8 @@ class UnzipProcessor : public ZipExtractorProcessor {
void concat_path(char* out, const size_t size,
const char *path1, const char *path2) {
int len1 = strlen(path1);
- int l = len1;
- strncpy(out, path1, size-1);
+ size_t l = len1;
+ strncpy(out, path1, size - 1);
out[size-1] = 0;
if (l < size - 1 && path1[len1] != '/' && path2[0] != '/') {
out[l] = '/';