diff options
author | Han-Wen Nienhuys <hanwen@google.com> | 2016-01-26 15:10:43 +0000 |
---|---|---|
committer | Kristina Chodorow <kchodorow@google.com> | 2016-01-27 15:02:06 +0000 |
commit | 122e6191900bfd1963420dbbe192d81e541adca5 (patch) | |
tree | a70ada8088b680d29fb2356be315cb86f540edb3 /third_party/py/mock/html/changelog.html | |
parent | 41f4456ac2348bef66739194853a1ddadcbb887e (diff) |
Return opaque value for native.rule() on a select() statement.
This is imperfect in many ways:
1) the value is opaque, and not a BUILD value, so it cannot be used
in rule arguments
2) its representation has a pointer address, so it breaks hermeticity.
Despite its problem, we return this value because otherwise
native.rules() fails if there is any rule using a select() in the
BUILD file.
A future solution would be to convert BuildType.SelectorList back to
syntax.SelectorList. To do so, we would have to
1) recurse into the Selector contents of SelectorList, so those values
are run through skylarkifyValue too
2) get the right Class<?> value. We could probably get at that by looking at
((SelectorList)val).getSelectors().first().getEntries().first().getClass().
--
MOS_MIGRATED_REVID=113051612
Diffstat (limited to 'third_party/py/mock/html/changelog.html')
0 files changed, 0 insertions, 0 deletions