diff options
| author |  László Csomor <laszlocsomor@google.com> | 2017-03-15 11:05:20 +0100 |
|---|---|---|
| committer | László Csomor <laszlocsomor@google.com> | 2017-03-15 16:45:31 +0100 |
| commit | 39014167557d0eb2c2f140e9a48a753e1200e9c2 (patch) | |
| tree | b9112e3fa13770cadfdab385fe536e477cc1c83e /third_party/grpc | |
| parent | eb46bedecfb54584905b800a493962351a4c0a51 (diff) | |
gRPC, Windows: add missing #include and warning
Add a missing header inclusion to string_win32.c
which was resulting in an implicit function
declaration with the wrong, but compatible type,
causing a char* being converted to int, converted
to char*, corrupting the upper 32 bits, leading to
a segfault.
Fixes https://github.com/bazelbuild/bazel/issues/2672
Change-Id: I805737c93c248f792b2c0f54fe15ab9a261575d2
Diffstat (limited to 'third_party/grpc')
| -rw-r--r-- | third_party/grpc/BUILD | 2 | ||||
| -rw-r--r-- | third_party/grpc/src/core/support/string_win32.c | 1 |
2 files changed, 2 insertions, 1 deletions
diff --git a/third_party/grpc/BUILD b/third_party/grpc/BUILD index deaefd0b2f..864d93cdb7 100644 --- a/third_party/grpc/BUILD +++ b/third_party/grpc/BUILD @@ -414,7 +414,7 @@ cc_library( ], copts = [ "-std=gnu99", - "-Wno-implicit-function-declaration", + "-Wimplicit-function-declaration", ], includes = [ ".", diff --git a/third_party/grpc/src/core/support/string_win32.c b/third_party/grpc/src/core/support/string_win32.c index 3b1f702cf1..aedc98792a 100644 --- a/third_party/grpc/src/core/support/string_win32.c +++ b/third_party/grpc/src/core/support/string_win32.c @@ -34,6 +34,7 @@ /* Posix code for gpr snprintf support. */ #include <grpc/support/port_platform.h> +#include <grpc/support/string_util.h> #ifdef GPR_WIN32 |