Fixing broken named anchors for common-attributes*.

RELNOTES:

--
MOS_MIGRATED_REVID=111951279

7 files changed, 31 insertions, 21 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/config/ConfigRuleClasses.java b/src/main/java/com/google/devtools/build/lib/analysis/config/ConfigRuleClasses.java
index 8ad856f795..591a38abdf 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/config/ConfigRuleClasses.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/config/ConfigRuleClasses.java
@@ -211,8 +211,8 @@ ${ATTRIBUTE_SIGNATURE}
 <p>
   Matches an expected configuration state (expressed as Blaze flags) for the purpose of triggering
   configurable attributes. See <a href="#select">select</a> for how to consume this rule and
-  <a href="#configurable-attributes">Configurable attributes</a> for an overview of
-  the general feature.
+  <a href="common-definitions.html#configurable-attributes">
+  Configurable attributes</a> for an overview of the general feature.
 
 ${ATTRIBUTE_DEFINITION}
 
@@ -259,7 +259,8 @@ config_setting(
 <p>The currently endorsed method for creating custom conditions that can't be expressed through
   dedicated build flags is through the --define flag. Use this flag with caution: it's not ideal
   and only endorsed for lack of a currently better workaround. See the
-  <a href="#configurable-attributes">Configurable attributes</a> section for more discussion.
+  <a href="common-definitions.html#configurable-attributes">
+  Configurable attributes</a> section for more discussion.
 </p>
 
 <p>Try to consolidate <code>config_setting</code> definitions as much as possible. In other words,
diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/cpp/BazelCppRuleClasses.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/cpp/BazelCppRuleClasses.java
index a6dca6f457..fe212372c2 100644
--- a/src/main/java/com/google/devtools/build/lib/bazel/rules/cpp/BazelCppRuleClasses.java
+++ b/src/main/java/com/google/devtools/build/lib/bazel/rules/cpp/BazelCppRuleClasses.java
@@ -253,7 +253,8 @@ public class BazelCppRuleClasses {
           Add these options to the C++ compilation command.
           ${SYNOPSIS}
           Subject to <a href="make-variables.html">"Make variable"</a> substitution and
-          <a href="#sh-tokenization">Bourne shell tokenization</a>.
+          <a href="common-definitions.html#sh-tokenization">
+          Bourne shell tokenization</a>.
           <p>Each string in this attribute is added in the given order to <code>COPTS</code>
           before compiling the binary target.
           The flags take effect only for compiling this target, not its dependencies,
@@ -304,7 +305,8 @@ public class BazelCppRuleClasses {
           The list of architecture-specific dependencies that are processed to create the target.
           <i>(Dictionary mapping strings to lists of
              <a href="../build-ref.html#labels">labels</a>; optional)</i>
-          <p><i><a href="#configurable-attributes">Configurable attributes</a> is a generalization
+          <p><i><a href="common-definitions.html#configurable-attributes">
+            Configurable attributes</a> is a generalization
             of the same concept that works for most rules and attributes. It deprecates
             <code>abi_deps</code>, which we intend to ultimately remove. Use configurable
             attributes over <code>abi_deps</code> whenever possible. When not possible, let
@@ -355,7 +357,8 @@ public class BazelCppRuleClasses {
           List of defines to add to the compile line.
           ${SYNOPSIS}
           Subject to <a href="make-variables.html">"Make" variable</a> substitution and
-          <a href="#sh-tokenization">Bourne shell tokenization</a>.
+          <a href="common-definitions.html#sh-tokenization">
+          Bourne shell tokenization</a>.
           Each string, which must consist of a single Bourne shell token,
           is prepended with <code>-D</code> and added to
           <code>COPTS</code>.
@@ -470,8 +473,9 @@ public class BazelCppRuleClasses {
           Add these flags to the C++ linker command.
           ${SYNOPSIS}
           Subject to <a href="make-variables.html">"Make" variable</a> substitution,
-          <a href="#sh-tokenization">Bourne shell tokenization</a>
-          and <a href="#label-expansion">label expansion</a>.
+          <a href="common-definitions.html#sh-tokenization">
+          Bourne shell tokenization</a> and
+          <a href="common-definitions.html#label-expansion">label expansion</a>.
           Each string in this attribute is added to <code>LINKOPTS</code> before
           linking the binary target.
           <p>
diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPyLibraryRule.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPyLibraryRule.java
index 62a6b3d4a3..ff51bd5c80 100644
--- a/src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPyLibraryRule.java
+++ b/src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPyLibraryRule.java
@@ -34,8 +34,9 @@ public final class BazelPyLibraryRule implements RuleDefinition {
         /* <!-- #BLAZE_RULE(py_library).ATTRIBUTE(deps) -->
         The list of other libraries to be linked in to the library target.
         ${SYNOPSIS}
-        See general comments about <code>deps</code>
-        at <a href="#common-attributes">Attributes common to all build rules</a>.
+        See general comments about <code>deps</code> at
+        <a href="common-definitions.html#common-attributes">
+        Attributes common to all build rules</a>.
         In practice, these arguments are treated like those in <code>srcs</code>;
         you may move items between these lists willy-nilly.  It's probably more
         readable to keep your <code>.py</code> files in your <code>srcs</code>.
@@ -44,8 +45,9 @@ public final class BazelPyLibraryRule implements RuleDefinition {
         /* <!-- #BLAZE_RULE(py_library).ATTRIBUTE(data) -->
         The list of files needed by this library at runtime.
         ${SYNOPSIS}
-        See general comments about <code>data</code>
-        at <a href="#common-attributes">Attributes common to all build rules</a>.
+        See general comments about <code>data</code> at
+        <a href="common-definitions.html#common-attributes">
+        Attributes common to all build rules</a>.
         <!-- #END_BLAZE_RULE.ATTRIBUTE --> */
 
         /* <!-- #BLAZE_RULE(py_library).ATTRIBUTE(srcs) -->
diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPyRuleClasses.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPyRuleClasses.java
index 4142f3658d..db2268854b 100644
--- a/src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPyRuleClasses.java
+++ b/src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPyRuleClasses.java
@@ -54,8 +54,9 @@ public final class BazelPyRuleClasses {
           /* <!-- #BLAZE_RULE($base_py).ATTRIBUTE(deps) -->
           The list of other libraries to be linked in to the binary target.
           ${SYNOPSIS}
-          See general comments about <code>deps</code>
-          at <a href="#common-attributes">Attributes common to all build rules</a>.
+          See general comments about <code>deps</code> at
+          <a href="common-definitions.html#common-attributes">
+          Attributes common to all build rules</a>.
           These can be
           <a href="#py_binary"><code>py_binary</code></a> rules,
           <a href="#py_library"><code>py_library</code></a> rules or
@@ -110,8 +111,9 @@ public final class BazelPyRuleClasses {
          /* <!-- #BLAZE_RULE($base_py_binary).ATTRIBUTE(data) -->
          The list of files needed by this binary at runtime.
          ${SYNOPSIS}
-         See general comments about <code>data</code>
-         at <a href="#common-attributes">Attributes common to all build rules</a>.
+         See general comments about <code>data</code> at
+         <a href="common-definitions.html#common-attributes">
+         Attributes common to all build rules</a>.
          Also see the <a href="#py_library.data"><code>data</code></a> argument of
          the <a href="#py_library"><code>py_library</code></a> rule for details.
          <!-- #END_BLAZE_RULE.ATTRIBUTE --> */
diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/sh/BazelShTestRule.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/sh/BazelShTestRule.java
index 758f533304..48892211d5 100644
--- a/src/main/java/com/google/devtools/build/lib/bazel/rules/sh/BazelShTestRule.java
+++ b/src/main/java/com/google/devtools/build/lib/bazel/rules/sh/BazelShTestRule.java
@@ -49,7 +49,8 @@ ${ATTRIBUTE_SIGNATURE}
 
 ${ATTRIBUTE_DEFINITION}
 
-<p>See the <a href="#common-attributes-tests">attributes common to all test rules (*_test)</a>.</p>
+<p>See the <a href="common-definitions.html#common-attributes-tests">
+attributes common to all test rules (*_test)</a>.</p>
 
 <h4 id="sh_test_examples">Examples</h4>
 
diff --git a/src/main/java/com/google/devtools/build/lib/rules/android/AndroidRuleClasses.java b/src/main/java/com/google/devtools/build/lib/rules/android/AndroidRuleClasses.java
index 07bbe0605e..09702fcf93 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/android/AndroidRuleClasses.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/android/AndroidRuleClasses.java
@@ -509,7 +509,7 @@ public final class AndroidRuleClasses {
           Extra compiler options for this target.
           ${SYNOPSIS}
           Subject to <a href="#make_variables">"Make variable"</a> substitution and
-          <a href="#sh-tokenization">Bourne shell tokenization</a>.
+          <a href="common-definitions.html#sh-tokenization">Bourne shell tokenization</a>.
           <p>
           These compiler options are passed to javac after the global compiler options.</p>
           <!-- #END_BLAZE_RULE.ATTRIBUTE --> */
@@ -596,7 +596,7 @@ public final class AndroidRuleClasses {
           Additional command-line flags for the dx tool when generating classes.dex.
           ${SYNOPSIS}
           Subject to <a href="#make_variables">"Make variable"</a> substitution and
-          <a href="#sh-tokenization">Bourne shell tokenization</a>.
+          <a href="common-definitions.html#sh-tokenization">Bourne shell tokenization</a>.
           <!-- #END_BLAZE_RULE.ATTRIBUTE --> */
           .add(attr("dexopts", STRING_LIST))
           /* <!-- #BLAZE_RULE($android_binary_base).ATTRIBUTE(dex_shards) -->
diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcRuleClasses.java b/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcRuleClasses.java
index 66d4e76c24..3330f7fec2 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcRuleClasses.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcRuleClasses.java
@@ -239,7 +239,7 @@ public class ObjcRuleClasses {
           Extra flags to pass to the compiler.
           ${SYNOPSIS}
           Subject to <a href="#make_variables">"Make variable"</a> substitution and
-          <a href="#sh-tokenization">Bourne shell tokenization</a>.
+          <a href="common-definitions.html#sh-tokenization">Bourne shell tokenization</a>.
           These flags will only apply to this target, and not those upon which
           it depends, or those which depend on it.
           <p>
@@ -708,7 +708,7 @@ public class ObjcRuleClasses {
            are) but also to all <code>objc_</code> dependers of this target.
            ${SYNOPSIS}
            Subject to <a href="#make_variables">"Make variable"</a> substitution and
-           <a href="#sh-tokenization">Bourne shell tokenization</a>.
+           <a href="common-definitions.html#sh-tokenization">Bourne shell tokenization</a>.
            <!-- #END_BLAZE_RULE.ATTRIBUTE -->*/
           .add(attr("defines", STRING_LIST))
           /* <!-- #BLAZE_RULE($objc_compiling_rule).ATTRIBUTE(enable_modules) -->