aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
diff options
context:
space:
mode:
authorGravatar Janak Ramakrishnan <janakr@google.com>2015-07-09 16:10:11 +0000
committerGravatar Han-Wen Nienhuys <hanwen@google.com>2015-07-10 17:19:05 +0000
commit878aa6c66dad51030306f2537c06b076cb69c8ff (patch)
treea400343823f3ef9ec31cb9098c0b78fe63a098a4 /src
parent8e0ae3ce8f545f5606e07c2e6198c3ea9e101afb (diff)
Improve error reporting in tests when there's an actual event/expected event mismatch.
-- MOS_MIGRATED_REVID=97878625
Diffstat (limited to 'src')
-rw-r--r--src/main/java/com/google/devtools/build/lib/events/EventCollector.java7
-rw-r--r--src/test/java/com/google/devtools/build/lib/testutil/JunitTestUtils.java2
2 files changed, 8 insertions, 1 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/events/EventCollector.java b/src/main/java/com/google/devtools/build/lib/events/EventCollector.java
index 774b3231f6..e8cc57ae4b 100644
--- a/src/main/java/com/google/devtools/build/lib/events/EventCollector.java
+++ b/src/main/java/com/google/devtools/build/lib/events/EventCollector.java
@@ -13,6 +13,8 @@
// limitations under the License.
package com.google.devtools.build.lib.events;
+import com.google.common.collect.Iterables;
+
import java.util.ArrayList;
import java.util.Collection;
import java.util.Iterator;
@@ -75,4 +77,9 @@ public class EventCollector extends AbstractEventHandler implements Iterable<Eve
public void clear() {
collected.clear();
}
+
+ @Override
+ public String toString() {
+ return "EventCollector: " + Iterables.toString(collected);
+ }
}
diff --git a/src/test/java/com/google/devtools/build/lib/testutil/JunitTestUtils.java b/src/test/java/com/google/devtools/build/lib/testutil/JunitTestUtils.java
index efe15992d5..ecb44ca768 100644
--- a/src/test/java/com/google/devtools/build/lib/testutil/JunitTestUtils.java
+++ b/src/test/java/com/google/devtools/build/lib/testutil/JunitTestUtils.java
@@ -304,7 +304,7 @@ public class JunitTestUtils {
}
}
List<Event> foundEvents = builder.build();
- assertWithMessage(foundEvents.toString()).that(foundEvents).hasSize(expectedFrequency);
+ assertWithMessage(events.toString()).that(foundEvents).hasSize(expectedFrequency);
return foundEvents;
}
}