diff options
| author |  mschaller <mschaller@google.com> | 2018-03-07 13:11:15 -0800 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-03-07 13:13:03 -0800 |
| commit | 643d389e718070eed1cf47f6703668c7d2a96f2d (patch) | |
| tree | dde7662bf1b3e6bc25f0c70d41495bc1f1452ee9 /src | |
| parent | 3068c0ed7eae3e1ff29ddd32d23def0bdfd42548 (diff) | |
Fix stale comment about selector entry order
RELNOTES: None.
PiperOrigin-RevId: 188221536
Diffstat (limited to 'src')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/packages/AttributeFormatter.java | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/packages/AttributeFormatter.java b/src/main/java/com/google/devtools/build/lib/packages/AttributeFormatter.java index f14ca5db7d..c3028afdd6 100644 --- a/src/main/java/com/google/devtools/build/lib/packages/AttributeFormatter.java +++ b/src/main/java/com/google/devtools/build/lib/packages/AttributeFormatter.java @@ -146,7 +146,8 @@ public class AttributeFormatter { .setHasDefaultValue(selector.hasDefault()); // Note that the order of entries returned by selector.getEntries is stable. The map's - // entries' order is preserved from the sorting performed by the SelectorValue constructor. + // entries' order is preserved from the fact that Skylark dictionary entry order is stable + // (it's determined by insertion order). for (Entry<Label, ?> entry : selector.getEntries().entrySet()) { Label condition = entry.getKey(); Builder selectorEntryBuilder = SelectorEntry.newBuilder() |