aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
diff options
context:
space:
mode:
authorGravatar janakr <janakr@google.com>2018-05-15 17:22:08 -0700
committerGravatar Copybara-Service <copybara-piper@google.com>2018-05-15 17:24:12 -0700
commit3aa9107ebefebbf4b98b382254ff83cfb8def865 (patch)
tree8f295b59101e6954259d7f3dafb267b7dec04183 /src
parent90e116c2358e2d1e71818f7d39ddb609581ee211 (diff)
Migrate some serialization tests to use SerializationTester rather than AbstractObjectCodecTest. I saw these tests causing errors in one version of the sequel unknown commit when testing detection of junk data, but not with this clean-up.
Also use the String codec provided in the context in AutoCodecProcessorTest. PiperOrigin-RevId: 196756537
Diffstat (limited to 'src')
-rw-r--r--src/test/java/com/google/devtools/build/lib/skyframe/serialization/ImmutableListCodecTest.java19
1 files changed, 8 insertions, 11 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/skyframe/serialization/ImmutableListCodecTest.java b/src/test/java/com/google/devtools/build/lib/skyframe/serialization/ImmutableListCodecTest.java
index 6591beec6a..8e94fac2ff 100644
--- a/src/test/java/com/google/devtools/build/lib/skyframe/serialization/ImmutableListCodecTest.java
+++ b/src/test/java/com/google/devtools/build/lib/skyframe/serialization/ImmutableListCodecTest.java
@@ -15,21 +15,18 @@
package com.google.devtools.build.lib.skyframe.serialization;
import com.google.common.collect.ImmutableList;
-import com.google.devtools.build.lib.skyframe.serialization.strings.StringCodecs;
-import com.google.devtools.build.lib.skyframe.serialization.testutils.AbstractObjectCodecTest;
+import com.google.devtools.build.lib.skyframe.serialization.testutils.SerializationTester;
+import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
/** Tests for {@link ImmutableListCodec}. */
@RunWith(JUnit4.class)
-public class ImmutableListCodecTest extends AbstractObjectCodecTest<ImmutableList<String>> {
-
- @SuppressWarnings("unchecked")
- public ImmutableListCodecTest() {
- super(
- new ImmutableListCodec<>(StringCodecs.simple()),
- ImmutableList.of(),
- ImmutableList.of("foo"),
- ImmutableList.of("bar", "baz"));
+public class ImmutableListCodecTest {
+ @Test
+ public void smoke() throws Exception {
+ new SerializationTester(
+ ImmutableList.of(), ImmutableList.of("foo"), ImmutableList.of("bar", "baz"))
+ .runTests();
}
}