diff options
author | Nathan Harmata <nharmata@google.com> | 2015-03-27 18:15:46 +0000 |
---|---|---|
committer | Ulf Adams <ulfjack@google.com> | 2015-03-30 12:18:36 +0000 |
commit | 267b0a1d34e73fdfa0a5fb6c5cc8f89a3700708b (patch) | |
tree | 700fcbf59222a88fa81d6ac99f588c0849d65e01 /src | |
parent | 6fc9fa05e5148c0996823dbaf8a6813d43c15c48 (diff) |
Clarify what "fancy" means.
--
MOS_MIGRATED_REVID=89710872
Diffstat (limited to 'src')
-rw-r--r-- | src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java b/src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java index b04fec642d..4f8dcfd229 100644 --- a/src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java +++ b/src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java @@ -353,8 +353,10 @@ public final class ParallelEvaluator implements Evaluator { } if (bubbleErrorInfo != null) { - // Set interrupted status, so that calling SkyFunction doesn't try anything fancy after - // this. + // Set interrupted status, to try to prevent the calling SkyFunction from doing anything + // fancy after this. SkyFunctions executed during error bubbling are supposed to + // (quickly) rethrow errors or return a value/null (but there's currently no way to + // enforce this). Thread.currentThread().interrupt(); } if (errorInfo.getException() != null) { |