diff options
author | 2015-09-23 16:54:19 +0000 | |
---|---|---|
committer | 2015-09-24 14:17:42 +0000 | |
commit | 1e597c85c6881b7cdf208397f4ad836c7f69185a (patch) | |
tree | 77b1432592038ceef80566fa7ef46b1e2e5524cc /src | |
parent | de667c6ee28525d2ee2517b2d3c49fb0e5c5f548 (diff) |
Simplify LoadingPhaseRunner; avoid an unnecessary Set copy.
--
MOS_MIGRATED_REVID=103754837
Diffstat (limited to 'src')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/pkgcache/LoadingPhaseRunner.java | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/pkgcache/LoadingPhaseRunner.java b/src/main/java/com/google/devtools/build/lib/pkgcache/LoadingPhaseRunner.java index 280123378b..0781b64e67 100644 --- a/src/main/java/com/google/devtools/build/lib/pkgcache/LoadingPhaseRunner.java +++ b/src/main/java/com/google/devtools/build/lib/pkgcache/LoadingPhaseRunner.java @@ -537,9 +537,8 @@ public class LoadingPhaseRunner { } } - private Collection<Target> getTargetsForLabels(Collection<Label> labels) { + private Set<Target> getTargetsForLabels(Collection<Label> labels) { Set<Target> result = new HashSet<>(); - for (Label label : labels) { try { result.add(packageManager.getLoadedTarget(label)); @@ -547,7 +546,6 @@ public class LoadingPhaseRunner { throw new IllegalStateException(e); // The target should have been loaded } } - return result; } @@ -573,7 +571,7 @@ public class LoadingPhaseRunner { } return ImmutableSet.copyOf(Sets.difference(ImmutableSet.copyOf(targetsToLoad), - ImmutableSet.copyOf(getTargetsForLabels(rootCauses.keySet())))); + getTargetsForLabels(rootCauses.keySet()))); } /** |