aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
diff options
context:
space:
mode:
authorGravatar Ulf Adams <ulfjack@google.com>2016-01-25 16:22:44 +0000
committerGravatar Kristina Chodorow <kchodorow@google.com>2016-01-25 16:52:34 +0000
commit14aaeb90d14fdd61f109f34d13710815253eaa93 (patch)
tree09bed3d8275e6ef0adb70928f8fc984b5b9fcf06 /src
parent5db44f222687c49c4284bd2f47d58cc8f6545e6b (diff)
Fix some generic warnings.
-- MOS_MIGRATED_REVID=112952552
Diffstat (limited to 'src')
-rw-r--r--src/main/java/com/google/devtools/build/lib/analysis/BuildView.java7
-rw-r--r--src/main/java/com/google/devtools/build/lib/packages/NativeAspectClass.java2
2 files changed, 4 insertions, 5 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/BuildView.java b/src/main/java/com/google/devtools/build/lib/analysis/BuildView.java
index 166879d62c..528ed0bbb4 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/BuildView.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/BuildView.java
@@ -471,17 +471,16 @@ public class BuildView {
skylarkFunctionName));
}
} else {
- @SuppressWarnings("unchecked")
final Class<? extends ConfiguredNativeAspectFactory> aspectFactoryClass =
- (Class<? extends ConfiguredNativeAspectFactory>)
- ruleClassProvider.getAspectFactoryMap().get(aspect);
+ ruleClassProvider.getAspectFactoryMap().get(aspect)
+ .asSubclass(ConfiguredNativeAspectFactory.class);
if (aspectFactoryClass != null) {
for (ConfiguredTargetKey targetSpec : targetSpecs) {
aspectKeys.add(
AspectValue.createAspectKey(
targetSpec.getLabel(),
targetSpec.getConfiguration(),
- new NativeAspectClass(aspectFactoryClass)));
+ new NativeAspectClass<ConfiguredNativeAspectFactory>(aspectFactoryClass)));
}
} else {
throw new ViewCreationFailedException("Aspect '" + aspect + "' is unknown");
diff --git a/src/main/java/com/google/devtools/build/lib/packages/NativeAspectClass.java b/src/main/java/com/google/devtools/build/lib/packages/NativeAspectClass.java
index 59bc6af3e1..62783dc111 100644
--- a/src/main/java/com/google/devtools/build/lib/packages/NativeAspectClass.java
+++ b/src/main/java/com/google/devtools/build/lib/packages/NativeAspectClass.java
@@ -56,7 +56,7 @@ public final class NativeAspectClass<T extends NativeAspectClass.NativeAspectFac
if (!(obj instanceof NativeAspectClass)) {
return false;
}
- return nativeClass.equals(((NativeAspectClass) obj).nativeClass);
+ return nativeClass.equals(((NativeAspectClass<?>) obj).nativeClass);
}
/**