aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/tools
diff options
context:
space:
mode:
authorGravatar Greg Estren <gregce@google.com>2016-11-16 17:44:16 +0000
committerGravatar Kristina Chodorow <kchodorow@google.com>2016-11-17 18:17:39 +0000
commitb0de919d8657d5809d9ab8315d4665926087d0b4 (patch)
treebe815408994aaa782f8a6e1a4b9d921f5e341fe6 /src/tools
parent2153790fbebaed4aef6544fea3a85a01749b0d11 (diff)
Fixes incomplete support for dynamic split transitions in Bazel's
test infrastructure. The small picture story is that SkyframeExecutor.getDynamicConfigOptions (which gets dynamic BuildOptions for tests) wasn't updated with dynamic split support when that was added to ConfiguredTargetFunction.getDynamicTransitionOptions (which does the same thing for production builds). This change plugs that gap. See 373e3e28274cca5b87f48abe33884edb84016dd3 for the original change. The bigger picture story is that Bazel's configured target creation logic is forked: test code goes down a similar but sadly not-quite-the-same path that results in tons of duplicated logic, spaghetti code mess, and risk of bugs like this one. We'd like to ultimately undo that fork. But unfortunately it's an involved effort that won't happen overnight. In the meantime, this change takes one small step by merging the two methods that caused this bug. -- MOS_MIGRATED_REVID=139342710
Diffstat (limited to 'src/tools')
0 files changed, 0 insertions, 0 deletions