diff options
| author |  laurentlb <laurentlb@google.com> | 2018-04-11 10:44:18 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-04-11 10:45:59 -0700 |
| commit | 51ae67a626aae45163175a1eee518b9e96e33fbc (patch) | |
| tree | cac9ee2481db4e5c799f3703db7e47aaf2055807 /src/tools/skylark | |
| parent | 5f135e8355b20a28a561c58f5631811fbf467248 (diff) | |
Warn when code uses FileType(), which is deprecated.
RELNOTES: None.
PiperOrigin-RevId: 192472412
Diffstat (limited to 'src/tools/skylark')
2 files changed, 3 insertions, 0 deletions
diff --git a/src/tools/skylark/java/com/google/devtools/skylark/skylint/DeprecatedApiChecker.java b/src/tools/skylark/java/com/google/devtools/skylark/skylint/DeprecatedApiChecker.java index a6fc1e761e..818796e33d 100644 --- a/src/tools/skylark/java/com/google/devtools/skylark/skylint/DeprecatedApiChecker.java +++ b/src/tools/skylark/java/com/google/devtools/skylark/skylint/DeprecatedApiChecker.java @@ -109,6 +109,7 @@ public class DeprecatedApiChecker extends AstVisitorWithNameResolution { .put("ctx.template_action", "Use ctx.actions.expand_template.") .put("PACKAGE_NAME", "Use native.package_name().") .put("REPOSITORY_NAME", "Use native.repository_name().") + .put("FileType", "Use a list of strings.") .put( "ctx.outputs.executable", "See https://docs.bazel.build/versions/master/skylark/" diff --git a/src/tools/skylark/javatests/com/google/devtools/skylark/skylint/DeprecatedApiCheckerTest.java b/src/tools/skylark/javatests/com/google/devtools/skylark/skylint/DeprecatedApiCheckerTest.java index e17251f263..cafe898dd4 100644 --- a/src/tools/skylark/javatests/com/google/devtools/skylark/skylint/DeprecatedApiCheckerTest.java +++ b/src/tools/skylark/javatests/com/google/devtools/skylark/skylint/DeprecatedApiCheckerTest.java @@ -46,6 +46,8 @@ public class DeprecatedApiCheckerTest { .contains("1:1-1:12: PACKAGE_NAME is deprecated"); Truth.assertThat(findIssues("f = ctx.outputs.executable").toString()) .contains("1:5-1:26: ctx.outputs.executable is deprecated"); + Truth.assertThat(findIssues("css_filetype = FileType(['.css'])").toString()) + .contains("1:16-1:23: FileType is deprecated"); Truth.assertThat(findIssues("ctx.actions()")).isEmpty(); } |