diff options
author | Googler <noreply@google.com> | 2018-02-13 12:22:38 -0800 |
---|---|---|
committer | Copybara-Service <copybara-piper@google.com> | 2018-02-13 12:24:07 -0800 |
commit | 2926ed6508f98e979e65b31ed33ea39052e2bfa0 (patch) | |
tree | 15bfc411bee979ad1430ee88c75964ab10dc9b56 /src/tools/skylark | |
parent | 537552028eb00c5939cdfa60702f57d716a949a3 (diff) |
Follow on to Cl/185417760 unifying error messages for glob linter.
I neglected to unify the message text before submit. This uses the Go version
for both go and Java.
R=laurentlb,mkanat
CC=blaze-firehose+cl
RELNOTES:
unifly lint glob(["**/*.java"]) message
PiperOrigin-RevId: 185569422
Diffstat (limited to 'src/tools/skylark')
-rw-r--r-- | src/tools/skylark/java/com/google/devtools/skylark/skylint/NativeRecursiveGlobChecker.java | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/src/tools/skylark/java/com/google/devtools/skylark/skylint/NativeRecursiveGlobChecker.java b/src/tools/skylark/java/com/google/devtools/skylark/skylint/NativeRecursiveGlobChecker.java index 0f8fe26d93..9857d6655b 100644 --- a/src/tools/skylark/java/com/google/devtools/skylark/skylint/NativeRecursiveGlobChecker.java +++ b/src/tools/skylark/java/com/google/devtools/skylark/skylint/NativeRecursiveGlobChecker.java @@ -73,10 +73,9 @@ public class NativeRecursiveGlobChecker extends AstVisitorWithNameResolution { Issue.create( BAD_RECURSIVE_GLOB, "go/build-style#globs " - + "Do not use recursive globs for Java source files. glob() on " - + "multiple directories is error prone, it can lead to import " - + "cycles between Java packages that are hard to break.", - exp.getLocation())); + + "Do not use recursive globs for Java source files. glob() on multiple " + + "directories is error prone and can cause serious maintenance problems for " + + "BUILD files.", exp.getLocation())); } } else if (exp.kind() == Expression.Kind.IDENTIFIER) { Identifier id = (Identifier) exp; |