diff options
author | 2018-03-07 13:35:41 -0800 | |
---|---|---|
committer | 2018-03-07 13:37:44 -0800 | |
commit | 164129638f382960d066893ab60a25333bec396d (patch) | |
tree | b22395bce166552abbd4744f1312834044efc749 /src/tools/skylark/javatests | |
parent | 643d389e718070eed1cf47f6703668c7d2a96f2d (diff) |
Skylint: check for PACKAGE_NAME, REPOSITORY_NAME, and ctx.outputs.executable
RELNOTES: None.
PiperOrigin-RevId: 188225156
Diffstat (limited to 'src/tools/skylark/javatests')
-rw-r--r-- | src/tools/skylark/javatests/com/google/devtools/skylark/skylint/DeprecatedApiCheckerTest.java | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/src/tools/skylark/javatests/com/google/devtools/skylark/skylint/DeprecatedApiCheckerTest.java b/src/tools/skylark/javatests/com/google/devtools/skylark/skylint/DeprecatedApiCheckerTest.java index 20af00dd12..0e356eac3e 100644 --- a/src/tools/skylark/javatests/com/google/devtools/skylark/skylint/DeprecatedApiCheckerTest.java +++ b/src/tools/skylark/javatests/com/google/devtools/skylark/skylint/DeprecatedApiCheckerTest.java @@ -37,11 +37,15 @@ public class DeprecatedApiCheckerTest { @Test public void deprecatedCtxMethods() { Truth.assertThat(findIssues("ctx.action()").toString()) - .contains("1:1-1:10: This method is deprecated"); + .contains("1:1-1:10: ctx.action is deprecated: Use ctx.actions.run"); Truth.assertThat(findIssues("ctx.empty_action").toString()) - .contains("1:1-1:16: This method is deprecated"); + .contains("1:1-1:16: ctx.empty_action is deprecated"); Truth.assertThat(findIssues("ctx.default_provider()").toString()) - .contains("1:1-1:20: This method is deprecated"); + .contains("1:1-1:20: ctx.default_provider is deprecated"); + Truth.assertThat(findIssues("PACKAGE_NAME").toString()) + .contains("1:1-1:12: PACKAGE_NAME is deprecated"); + Truth.assertThat(findIssues("f = ctx.outputs.executable").toString()) + .contains("1:5-1:26: ctx.outputs.executable is deprecated"); Truth.assertThat(findIssues("ctx.actions()")).isEmpty(); } |