Skylint: check provider names for the suffix "Info"

RELNOTES: none
PiperOrigin-RevId: 173113056

1 files changed, 7 insertions, 1 deletions

diff --git a/src/tools/skylark/javatests/com/google/devtools/skylark/skylint/NamingConventionsCheckerTest.java b/src/tools/skylark/javatests/com/google/devtools/skylark/skylint/NamingConventionsCheckerTest.java
index 6361705c29..f152d838af 100644
--- a/src/tools/skylark/javatests/com/google/devtools/skylark/skylint/NamingConventionsCheckerTest.java
+++ b/src/tools/skylark/javatests/com/google/devtools/skylark/skylint/NamingConventionsCheckerTest.java
@@ -106,12 +106,18 @@ public class NamingConventionsCheckerTest {
 
   @Test
   public void testProviderNameMustBeCamelCase() throws Exception {
-    Truth.assertThat(findIssues("FooBar = provider()")).isEmpty();
+    Truth.assertThat(findIssues("FooBarInfo = provider()")).isEmpty();
     Truth.assertThat(findIssues("foo_bar = provider()").toString())
         .contains("provider name 'foo_bar' should be UpperCamelCase [name-with-wrong-case]");
   }
 
   @Test
+  public void testProviderNameMustEndInInfo() throws Exception {
+    Truth.assertThat(findIssues("FooBar = provider()").toString())
+        .contains("provider name 'FooBar' should end in the suffix 'Info' [provider-name-suffix]");
+  }
+
+  @Test
   public void testNoDuplicates() throws Exception {
     Truth.assertThat(findIssues("def foo():", "  badName = 1", "  badName += 1")).hasSize(1);
     Truth.assertThat(findIssues("def foo():", "  Bad = 1", "  [[] for Bad in []]")).hasSize(2);