aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/tools/skylark/javatests/com/google/devtools/skylark
diff options
context:
space:
mode:
authorGravatar laurentlb <laurentlb@google.com>2017-11-30 06:08:12 -0800
committerGravatar Copybara-Service <copybara-piper@google.com>2017-11-30 06:10:16 -0800
commit52390cfb4c7609761ac08cbe1ba8772b65635538 (patch)
tree96d663d4f555dde2eb14e2a207b45a9780b525ba /src/tools/skylark/javatests/com/google/devtools/skylark
parentef23ba57f2565fa6f049aa26ebd695c0fdfdcc60 (diff)
Skylint: Add a warning for the '|' operator.
Also, minor fix for the += operator check. RELNOTES: None. PiperOrigin-RevId: 177444203
Diffstat (limited to 'src/tools/skylark/javatests/com/google/devtools/skylark')
-rw-r--r--src/tools/skylark/javatests/com/google/devtools/skylark/skylint/BadOperationCheckerTest.java10
1 files changed, 8 insertions, 2 deletions
diff --git a/src/tools/skylark/javatests/com/google/devtools/skylark/skylint/BadOperationCheckerTest.java b/src/tools/skylark/javatests/com/google/devtools/skylark/skylint/BadOperationCheckerTest.java
index ce121ffb59..9d0a9bc592 100644
--- a/src/tools/skylark/javatests/com/google/devtools/skylark/skylint/BadOperationCheckerTest.java
+++ b/src/tools/skylark/javatests/com/google/devtools/skylark/skylint/BadOperationCheckerTest.java
@@ -46,7 +46,7 @@ public class BadOperationCheckerTest {
+ " [deprecated-plus-dict]");
Truth.assertThat(findIssues("foo += {}").toString())
.contains(
- "1:1-1:9: '+' operator is deprecated and should not be used on dictionaries"
+ "1:1-1:9: '+=' operator is deprecated and should not be used on dictionaries"
+ " [deprecated-plus-dict]");
}
@@ -62,7 +62,7 @@ public class BadOperationCheckerTest {
+ " [deprecated-plus-dict]");
Truth.assertThat(findIssues("foo += {k:v for k,v in []}").toString())
.contains(
- "1:1-1:26: '+' operator is deprecated and should not be used on dictionaries"
+ "1:1-1:26: '+=' operator is deprecated and should not be used on dictionaries"
+ " [deprecated-plus-dict]");
}
@@ -79,6 +79,12 @@ public class BadOperationCheckerTest {
}
@Test
+ public void pipeOperator() {
+ Truth.assertThat(findIssues("foo | bar").toString())
+ .contains("1:1-1:9: '|' operator is deprecated");
+ }
+
+ @Test
public void plusOperatorNoIssue() {
Truth.assertThat(findIssues("foo + bar")).isEmpty();
Truth.assertThat(findIssues("foo += bar")).isEmpty();