diff options
| author |  Loo Rong Jie <loorongjie@gmail.com> | 2018-06-28 02:31:02 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-06-28 02:33:33 -0700 |
| commit | 74a9f015270083d51e0e32e8390a33c3aecb9a2c (patch) | |
| tree | 3d794a3187a0520675c891686f3ac75252e990f0 /src/tools/launcher/launcher.h | |
| parent | 3dc384760a141f23ffdd098066d9e0661a20430f (diff) | |
Add virtual destructor and override to BinaryLauncherBase and subclasses
Class with virtual functions must have virtual destructor. Subclasses should annotate overriden functions as `override`.
Found by Clang's `-Winconsistent-missing-override`.
Closes #5474.
PiperOrigin-RevId: 202445230
Diffstat (limited to 'src/tools/launcher/launcher.h')
| -rw-r--r-- | src/tools/launcher/launcher.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/tools/launcher/launcher.h b/src/tools/launcher/launcher.h index 107ac17795..a5f6920b57 100644 --- a/src/tools/launcher/launcher.h +++ b/src/tools/launcher/launcher.h @@ -42,6 +42,8 @@ class BinaryLauncherBase { BinaryLauncherBase(const LaunchDataParser::LaunchInfo& launch_info, int argc, wchar_t* argv[]); + virtual ~BinaryLauncherBase() = default; + // Get launch information based on a launch info key. std::wstring GetLaunchInfoByKey(const std::string& key); |