aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/tools/android/java/com
diff options
context:
space:
mode:
authorGravatar cnsun <cnsun@google.com>2017-08-02 21:05:22 +0200
committerGravatar Dmitry Lomov <dslomov@google.com>2017-08-03 12:09:56 +0200
commit2714195feae97333bca4ef0896c416f5f07b2f92 (patch)
tree3d3453beac91391a64f86a96ea2ee0c3ca6f57dd /src/tools/android/java/com
parentd77db9d3237697cc18eed5bd43738937e9358a83 (diff)
Alter the order of class visitors, to make sure that Objects.requireNonNUll
and Long.compare are correctly handled. RELNOTES: None PiperOrigin-RevId: 164018569
Diffstat (limited to 'src/tools/android/java/com')
-rw-r--r--src/tools/android/java/com/google/devtools/build/android/desugar/Desugar.java28
1 files changed, 14 insertions, 14 deletions
diff --git a/src/tools/android/java/com/google/devtools/build/android/desugar/Desugar.java b/src/tools/android/java/com/google/devtools/build/android/desugar/Desugar.java
index dba77a4443..29d820650e 100644
--- a/src/tools/android/java/com/google/devtools/build/android/desugar/Desugar.java
+++ b/src/tools/android/java/com/google/devtools/build/android/desugar/Desugar.java
@@ -491,6 +491,14 @@ class Desugar {
new TryWithResourcesRewriter(
visitor, loader, visitedExceptionTypes, numOfTryWithResourcesInvoked);
}
+ if (!allowCallsToObjectsNonNull) {
+ // Not sure whether there will be implicit null check emitted by javac, so we rerun
+ // the inliner again
+ visitor = new ObjectsRequireNonNullMethodRewriter(visitor);
+ }
+ if (!allowCallsToLongCompare) {
+ visitor = new LongCompareMethodRewriter(visitor);
+ }
if (outputJava7) {
// null ClassReaderFactory b/c we don't expect to need it for lambda classes
visitor = new Java7Compatibility(visitor, (ClassReaderFactory) null);
@@ -514,14 +522,6 @@ class Desugar {
visitor =
new LambdaDesugaring(
visitor, loader, lambdas, null, ImmutableSet.of(), allowDefaultMethods);
- if (!allowCallsToObjectsNonNull) {
- // Not sure whether there will be implicit null check emitted by javac, so we rerun
- // the inliner again
- visitor = new ObjectsRequireNonNullMethodRewriter(visitor);
- }
- if (!allowCallsToLongCompare) {
- visitor = new LongCompareMethodRewriter(visitor);
- }
return visitor;
}
@@ -543,6 +543,12 @@ class Desugar {
new TryWithResourcesRewriter(
visitor, loader, visitedExceptionTypes, numOfTryWithResourcesInvoked);
}
+ if (!allowCallsToObjectsNonNull) {
+ visitor = new ObjectsRequireNonNullMethodRewriter(visitor);
+ }
+ if (!allowCallsToLongCompare) {
+ visitor = new LongCompareMethodRewriter(visitor);
+ }
if (!options.onlyDesugarJavac9ForLint) {
if (outputJava7) {
visitor = new Java7Compatibility(visitor, classpathReader);
@@ -561,12 +567,6 @@ class Desugar {
lambdaMethodsUsedInInvokeDynamic,
allowDefaultMethods);
}
- if (!allowCallsToObjectsNonNull) {
- visitor = new ObjectsRequireNonNullMethodRewriter(visitor);
- }
- if (!allowCallsToLongCompare) {
- visitor = new LongCompareMethodRewriter(visitor);
- }
return visitor;
}