aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/tools/android/java/com/google/devtools/build/android/ScopedTemporaryDirectory.java
diff options
context:
space:
mode:
authorGravatar ajmichael <ajmichael@google.com>2017-10-04 07:31:31 +0200
committerGravatar Klaus Aehlig <aehlig@google.com>2017-10-06 19:43:33 +0200
commit2b7dc0555adcbfa354b964683ab525e61a96b6df (patch)
treee957bdb34d2da5e1f472b69f9db0f0f433fc8e9e /src/tools/android/java/com/google/devtools/build/android/ScopedTemporaryDirectory.java
parenta7cb14e16dd4ba760b444a97a687fd65a9d7f3a7 (diff)
Only make files writable before processing on Windows.
Prior to https://github.com/bazelbuild/bazel/commit/560b0ae4701dd2084160c45bb772396535b31f47, this was only done on Windows. This is super slow on mac for libraries with thousands of resources. RELNOTES: None PiperOrigin-RevId: 170964688
Diffstat (limited to 'src/tools/android/java/com/google/devtools/build/android/ScopedTemporaryDirectory.java')
-rw-r--r--src/tools/android/java/com/google/devtools/build/android/ScopedTemporaryDirectory.java8
1 files changed, 6 insertions, 2 deletions
diff --git a/src/tools/android/java/com/google/devtools/build/android/ScopedTemporaryDirectory.java b/src/tools/android/java/com/google/devtools/build/android/ScopedTemporaryDirectory.java
index e9c1ca6a48..9c3f5ceb11 100644
--- a/src/tools/android/java/com/google/devtools/build/android/ScopedTemporaryDirectory.java
+++ b/src/tools/android/java/com/google/devtools/build/android/ScopedTemporaryDirectory.java
@@ -74,13 +74,17 @@ final class ScopedTemporaryDirectory extends SimpleFileVisitor<Path> implements
@Override
public FileVisitResult preVisitDirectory(Path dir, BasicFileAttributes attrs) throws IOException {
- makeWritable(dir);
+ if (IS_WINDOWS) {
+ makeWritable(dir);
+ }
return FileVisitResult.CONTINUE;
}
@Override
public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) throws IOException {
- makeWritable(file);
+ if (IS_WINDOWS) {
+ makeWritable(file);
+ }
Files.delete(file);
return FileVisitResult.CONTINUE;
}