diff options
author | apell <apell@google.com> | 2017-07-21 19:26:42 +0200 |
---|---|---|
committer | Jakob Buchgraber <buchgr@google.com> | 2017-07-24 09:51:14 +0200 |
commit | 92cd50ebc7579cec7760fe6515e680a31064b6ed (patch) | |
tree | 2e792ab4144682d4f58c8339b39ee62be6513cd3 /src/tools/android/java/com/google/devtools/build/android/ManifestMergerAction.java | |
parent | 8aa6745498bd4a3868336755b0fd198e0c31d81f (diff) |
Stop reporting manifest merge errors as exceptions with stack traces as well as printing the merge error report. The stack traces duplicated the error report and gave the impression that the error may be an internal error instead of a build error.
RELNOTES: None.
PiperOrigin-RevId: 162755827
Diffstat (limited to 'src/tools/android/java/com/google/devtools/build/android/ManifestMergerAction.java')
-rw-r--r-- | src/tools/android/java/com/google/devtools/build/android/ManifestMergerAction.java | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/tools/android/java/com/google/devtools/build/android/ManifestMergerAction.java b/src/tools/android/java/com/google/devtools/build/android/ManifestMergerAction.java index 1862fc238f..2bd9a7756b 100644 --- a/src/tools/android/java/com/google/devtools/build/android/ManifestMergerAction.java +++ b/src/tools/android/java/com/google/devtools/build/android/ManifestMergerAction.java @@ -18,6 +18,7 @@ import static java.util.logging.Level.SEVERE; import com.android.manifmerger.ManifestMerger2.MergeType; import com.android.utils.StdLogger; import com.google.common.collect.ImmutableMap; +import com.google.devtools.build.android.AndroidManifestProcessor.MergeErrorException; import com.google.devtools.build.android.Converters.ExistingPathConverter; import com.google.devtools.build.android.Converters.ExistingPathStringDictionaryConverter; import com.google.devtools.build.android.Converters.MergeTypeConverter; @@ -223,7 +224,9 @@ public class ManifestMergerAction { // Set to the epoch for caching purposes. Files.setLastModifiedTime(options.manifestOutput, FileTime.fromMillis(0L)); - } catch (IOException e) { + } catch (MergeErrorException e) { + System.exit(1); + } catch (Exception e) { logger.log(SEVERE, "Error during merging manifests", e); throw e; } |