diff options
author | Googler <noreply@google.com> | 2016-04-05 17:52:42 +0000 |
---|---|---|
committer | Lukacs Berki <lberki@google.com> | 2016-04-07 11:40:01 +0000 |
commit | 0f86dc815c46f5bde00e42fc875ed0502a1fac44 (patch) | |
tree | 54661f592792a5c35f6e7b5ec0134f995dcaebf4 /src/tools/android/java/com/google/devtools/build/android/DataResourceXml.java | |
parent | c0b4e2c5cc15c749afba7a238d6337c7c4d66004 (diff) |
4.25 of 5: Writing of UnwrittenMergedAndroidData
Introduces the AndroidDataWriter and AndroidDataWritingVisitor to abstract the io operations from the data classes.
Necessary refactoring to the stubbed write method on DataValue in DataAsset.writeAsset and DataResource.writeResource.
New interface for the AttributeValues to reflect the simplifications of writing Resource Attributes.
Of special note is the fact all xml is written into a single file, values.xml. This is following the Gradle convention and aapt has demonstrated a preference of only reading a values.xml and ignoring all other xml files in the values directory. Unless profiling demonstrates an advantage to writing multiple files (which I doubt), this merger carries on this convention.
--
MOS_MIGRATED_REVID=119066611
Diffstat (limited to 'src/tools/android/java/com/google/devtools/build/android/DataResourceXml.java')
-rw-r--r-- | src/tools/android/java/com/google/devtools/build/android/DataResourceXml.java | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/src/tools/android/java/com/google/devtools/build/android/DataResourceXml.java b/src/tools/android/java/com/google/devtools/build/android/DataResourceXml.java index ac5b392800..21e8c92657 100644 --- a/src/tools/android/java/com/google/devtools/build/android/DataResourceXml.java +++ b/src/tools/android/java/com/google/devtools/build/android/DataResourceXml.java @@ -58,7 +58,7 @@ public class DataResourceXml implements DataResource { * @throws FactoryConfigurationError Thrown with the {@link XMLInputFactory} is misconfigured. * @throws IOException Thrown when there is an error reading a file. */ - public static void fromPath( + public static void parse( XMLInputFactory xmlInputFactory, Path path, Factory fqnFactory, @@ -160,8 +160,7 @@ public class DataResourceXml implements DataResource { } @Override - public void write(Path newResourceDirectory) throws IOException { - // TODO(corysmith): Implement write. - throw new UnsupportedOperationException(); + public void writeResource(FullyQualifiedName key, AndroidDataWritingVisitor mergedDataWriter) { + xml.write(key, source, mergedDataWriter); } } |