Skylark rules can no longer overwrite built-in attributes.

--
MOS_MIGRATED_REVID=103931317

1 files changed, 7 insertions, 0 deletions

diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java
index c7ea6920b8..cce9b97a71 100644
--- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java
+++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java
@@ -66,6 +66,13 @@ public class SkylarkRuleClassFunctionsTest extends SkylarkTestCase {
         ")");
   }
 
+  public void testCannotOverrideBuiltInAttribute() throws Exception {
+    checkEvalError(
+        "There is already a built-in attribute 'tags' which cannot be overridden",
+        "def impl(ctx): return",
+        "r = rule(impl, attrs = {'tags': attr.string_list()})");
+  }
+
   public void testImplicitArgsAttribute() throws Exception {
     eval(
         "def _impl(ctx):",