aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/test
diff options
context:
space:
mode:
authorGravatar mjhalupka <mjhalupka@google.com>2018-06-13 14:19:26 -0700
committerGravatar Copybara-Service <copybara-piper@google.com>2018-06-13 14:21:00 -0700
commite253f83306d155f9241493c1a8ca932760fd85a3 (patch)
tree142be67a0af09913a4f8a6e22bcabaab11f64ced /src/test
parent53179466fa10aad99c0660b68544561a2b6faade (diff)
Fix filterTestsByTarget to filter by label instead of filtering by doing
package lookups to get Targets. PiperOrigin-RevId: 200452642
Diffstat (limited to 'src/test')
-rw-r--r--src/test/java/com/google/devtools/build/lib/analysis/BuildViewTest.java6
1 files changed, 1 insertions, 5 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/analysis/BuildViewTest.java b/src/test/java/com/google/devtools/build/lib/analysis/BuildViewTest.java
index d5f8771902..ee19db1635 100644
--- a/src/test/java/com/google/devtools/build/lib/analysis/BuildViewTest.java
+++ b/src/test/java/com/google/devtools/build/lib/analysis/BuildViewTest.java
@@ -39,7 +39,6 @@ import com.google.devtools.build.lib.analysis.util.BuildViewTestBase;
import com.google.devtools.build.lib.analysis.util.ExpectedTrimmedConfigurationErrors;
import com.google.devtools.build.lib.analysis.util.MockRule;
import com.google.devtools.build.lib.cmdline.Label;
-import com.google.devtools.build.lib.events.NullEventHandler;
import com.google.devtools.build.lib.events.OutputFilter.RegexOutputFilter;
import com.google.devtools.build.lib.packages.BuildType;
import com.google.devtools.build.lib.packages.Rule;
@@ -132,10 +131,7 @@ public class BuildViewTest extends BuildViewTestBase {
targets =
Lists.<ConfiguredTarget>newArrayList(
BuildView.filterTestsByTargets(
- targets,
- Sets.newHashSet(test1.getTarget(), suite.getTarget()),
- NullEventHandler.INSTANCE,
- skyframeExecutor.getPackageManager()));
+ targets, Sets.newHashSet(test1.getTarget(), suite.getTarget())));
assertThat(targets).containsExactlyElementsIn(Sets.newHashSet(test1CT, suiteCT));
}