diff options
author | dannark <dannark@google.com> | 2018-06-22 11:44:27 -0700 |
---|---|---|
committer | Copybara-Service <copybara-piper@google.com> | 2018-06-22 11:46:15 -0700 |
commit | da327bbeaf01ac109bf6262cda765c99228eddee (patch) | |
tree | 5677f7f9136eac0616e3df3fd68153b0d53c4fff /src/test | |
parent | ecc922017637b19cbd98381f4a0067b5422d2d31 (diff) |
Remove Label.parseAbsolute(string, boolean). The goal is to get rid of all label methods that don't explicitly pass a repository mapping.
RELNOTES: None
PiperOrigin-RevId: 201717665
Diffstat (limited to 'src/test')
-rw-r--r-- | src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java | 29 |
1 files changed, 25 insertions, 4 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java index 36c172b5f7..1f75b1e64e 100644 --- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java +++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java @@ -355,7 +355,11 @@ public class SkylarkRuleClassFunctionsTest extends SkylarkTestCase { Attribute attribute = Iterables.getOnlyElement(aspect.getAttributes()); assertThat(attribute.getName()).isEqualTo("$extra_deps"); assertThat(attribute.getDefaultValue(null)) - .isEqualTo(Label.parseAbsolute("//foo/bar:baz", false)); + .isEqualTo( + Label.parseAbsolute( + "//foo/bar:baz", + /* defaultToMain= */ false, + /* repositoryMapping= */ ImmutableMap.of())); } @Test @@ -467,19 +471,36 @@ public class SkylarkRuleClassFunctionsTest extends SkylarkTestCase { public void testLabelAttrDefaultValueAsString() throws Exception { Attribute sligleAttr = buildAttribute("a1", "attr.label(default = '//foo:bar')"); assertThat(sligleAttr.getDefaultValueForTesting()) - .isEqualTo(Label.parseAbsolute("//foo:bar", false)); + .isEqualTo( + Label.parseAbsolute( + "//foo:bar", + /* defaultToMain= */ false, + /* repositoryMapping= */ ImmutableMap.of())); Attribute listAttr = buildAttribute("a2", "attr.label_list(default = ['//foo:bar', '//bar:foo'])"); assertThat(listAttr.getDefaultValueForTesting()) .isEqualTo( ImmutableList.of( - Label.parseAbsolute("//foo:bar", false), Label.parseAbsolute("//bar:foo", false))); + Label.parseAbsolute( + "//foo:bar", + /* defaultToMain= */ false, + /* repositoryMapping= */ ImmutableMap.of()), + Label.parseAbsolute( + "//bar:foo", + /* defaultToMain= */ false, + /*repositoryMapping= */ ImmutableMap.of()))); Attribute dictAttr = buildAttribute("a3", "attr.label_keyed_string_dict(default = {'//foo:bar': 'my value'})"); assertThat(dictAttr.getDefaultValueForTesting()) - .isEqualTo(ImmutableMap.of(Label.parseAbsolute("//foo:bar", false), "my value")); + .isEqualTo( + ImmutableMap.of( + Label.parseAbsolute( + "//foo:bar", + /* defaultToMain= */ false, + /* repositoryMapping= */ ImmutableMap.of()), + "my value")); } @Test |