diff options
| author |  brendandouglas <brendandouglas@google.com> | 2018-06-08 16:00:09 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-06-08 16:02:01 -0700 |
| commit | d53d72e2841cd7e2c007751415679f9ff8a73062 (patch) | |
| tree | 24f6405196c21ab7e33c5af611b85e4b51f9491f /src/test | |
| parent | 9c68c3a1bd50ee56b5b7592a5f2ff918b16a2bab (diff) | |
Skylark debugging protocol: include frames information in ThreadPausedEvents.
This is almost always desirable -- if a thread is paused, the IDE expects
to know the context.
PiperOrigin-RevId: 199865078
Diffstat (limited to 'src/test')
| -rw-r--r-- | src/test/java/com/google/devtools/build/lib/skylarkdebug/server/SkylarkDebugServerTest.java | 18 |
1 files changed, 17 insertions, 1 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/skylarkdebug/server/SkylarkDebugServerTest.java b/src/test/java/com/google/devtools/build/lib/skylarkdebug/server/SkylarkDebugServerTest.java index d6674931fb..8aea1889d7 100644 --- a/src/test/java/com/google/devtools/build/lib/skylarkdebug/server/SkylarkDebugServerTest.java +++ b/src/test/java/com/google/devtools/build/lib/skylarkdebug/server/SkylarkDebugServerTest.java @@ -169,7 +169,7 @@ public class SkylarkDebugServerTest { Environment env = newEnvironment(); Location breakpoint = - Location.newBuilder().setLineNumber(2).setPath("/a/build/file/BUILD").build(); + Location.newBuilder().setLineNumber(1).setPath("/a/build/file/BUILD").build(); setBreakpoints(ImmutableList.of(breakpoint)); Thread evaluationThread = execInWorkerThread(buildFile, env); @@ -179,6 +179,22 @@ public class SkylarkDebugServerTest { // wait for breakpoint to be hit client.waitForEvent(DebugEvent::hasThreadPaused, Duration.ofSeconds(5)); + assertThat(client.unnumberedEvents) + .contains( + DebugEventHelper.threadPausedEvent( + SkylarkDebuggingProtos.Thread.newBuilder() + .setName(threadName) + .setId(threadId) + .setIsPaused(true) + .setLocation(breakpoint.toBuilder().setColumnNumber(1)) + .build(), + ImmutableList.of( + Frame.newBuilder() + .setFunctionName("<top level>") + .setLocation(breakpoint.toBuilder().setColumnNumber(1)) + .addScope(Scope.newBuilder().setName("global")) + .build()))); + assertThat(listThreads().getThreadList()) .containsExactly( SkylarkDebuggingProtos.Thread.newBuilder() |