diff options
author | Googler <noreply@google.com> | 2018-02-23 02:57:20 -0800 |
---|---|---|
committer | Copybara-Service <copybara-piper@google.com> | 2018-02-23 02:59:28 -0800 |
commit | c0faa4d480253ce51a239b8059659f6174c2380c (patch) | |
tree | ce76bc21c5f1431d124d99be1980f2bdffef5d2d /src/test | |
parent | 32243cbe980ebea1e09d60f0cccbb27cc0d40175 (diff) |
Document ambigious literal arguments when calling CcToolchainProvider constructor
RELNOTES: None.
PiperOrigin-RevId: 186744674
Diffstat (limited to 'src/test')
-rw-r--r-- | src/test/java/com/google/devtools/build/lib/rules/cpp/CcToolchainProviderTest.java | 117 |
1 files changed, 58 insertions, 59 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcToolchainProviderTest.java b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcToolchainProviderTest.java index ac98ea1c19..31fa26c574 100644 --- a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcToolchainProviderTest.java +++ b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcToolchainProviderTest.java @@ -22,7 +22,6 @@ import com.google.devtools.build.lib.collect.nestedset.NestedSetBuilder; import com.google.devtools.build.lib.collect.nestedset.Order; import com.google.devtools.build.lib.rules.cpp.CcToolchainFeatures.Variables; import com.google.devtools.build.lib.rules.cpp.FdoSupport.FdoMode; -import com.google.devtools.build.lib.util.Pair; import com.google.devtools.build.lib.vfs.PathFragment; import org.junit.Test; import org.junit.runner.RunWith; @@ -37,72 +36,72 @@ public class CcToolchainProviderTest { public void equalityIsObjectIdentity() throws Exception { CcToolchainProvider a = new CcToolchainProvider( - ImmutableMap.of(), - null, - null, - null, - NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), - NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), - NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), - NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), - NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), - NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), - NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), - NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), - null, - NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), - NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), - NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), - NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), - null, - NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), - null, - PathFragment.EMPTY_FRAGMENT, + /* skylarkToolchain= */ ImmutableMap.of(), + /* cppConfiguration= */ null, + /* toolchainInfo= */ null, + /* crosstoolTopPathFragment= */ null, + /* crosstool= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), + /* crosstoolMiddleman= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), + /* compile= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), + /* strip= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), + /* objCopy= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), + /* as= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), + /* ar= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), + /* link= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), + /* interfaceSoBuilder= */ null, + /* dwp= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), + /* coverage= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), + /* libcLink= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), + /* staticRuntimeLinkInputs= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), + /* staticRuntimeLinkMiddleman= */ null, + /* dynamicRuntimeLinkInputs= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), + /* dynamicRuntimeLinkMiddleman= */ null, + /* dynamicRuntimeSolibDir= */ PathFragment.EMPTY_FRAGMENT, CcCompilationInfo.EMPTY, - false, - false, + /* supportsParamFiles= */ false, + /* supportsHeaderParsing= */ false, Variables.EMPTY, - ImmutableList.<Artifact>of(), - NestedSetBuilder.<Pair<String, String>>emptySet(Order.COMPILE_ORDER), - null, - ImmutableMap.<String, String>of(), - ImmutableList.<PathFragment>of(), - null, + /* builtinIncludeFiles= */ ImmutableList.<Artifact>of(), + /* coverageEnvironment= */ NestedSetBuilder.emptySet(Order.COMPILE_ORDER), + /* linkDynamicLibraryTool= */ null, + /* environment= */ ImmutableMap.<String, String>of(), + /* builtInIncludeDirectories= */ ImmutableList.<PathFragment>of(), + /* sysroot= */ null, FdoMode.OFF); CcToolchainProvider b = new CcToolchainProvider( - ImmutableMap.of(), - null, - null, - null, - NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), - NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), - NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), - NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), - NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), - NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), - NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), - NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), - null, - NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), - NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), - NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), - NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), - null, - NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), - null, - PathFragment.EMPTY_FRAGMENT, + /* skylarkToolchain= */ ImmutableMap.of(), + /* cppConfiguration= */ null, + /* toolchainInfo= */ null, + /* crosstoolTopPathFragment= */ null, + /* crosstool= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), + /* crosstoolMiddleman= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), + /* compile= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), + /* strip= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), + /* objCopy= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), + /* as= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), + /* ar= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), + /* link= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), + /* interfaceSoBuilder= */ null, + /* dwp= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), + /* coverage= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), + /* libcLink= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), + /* staticRuntimeLinkInputs= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), + /* staticRuntimeLinkMiddleman= */ null, + /* dynamicRuntimeLinkInputs= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER), + /* dynamicRuntimeLinkMiddleman= */ null, + /* dynamicRuntimeSolibDir= */ PathFragment.EMPTY_FRAGMENT, CcCompilationInfo.EMPTY, - false, - false, + /* supportsParamFiles= */ false, + /* supportsHeaderParsing= */ false, Variables.EMPTY, - ImmutableList.<Artifact>of(), - NestedSetBuilder.<Pair<String, String>>emptySet(Order.COMPILE_ORDER), - null, - ImmutableMap.<String, String>of(), - ImmutableList.<PathFragment>of(), - null, + /* builtinIncludeFiles= */ ImmutableList.<Artifact>of(), + /* coverageEnvironment= */ NestedSetBuilder.emptySet(Order.COMPILE_ORDER), + /* linkDynamicLibraryTool= */ null, + /* environment= */ ImmutableMap.<String, String>of(), + /* builtInIncludeDirectories= */ ImmutableList.<PathFragment>of(), + /* sysroot= */ null, FdoMode.OFF); new EqualsTester() |