diff options
author | 2018-03-10 06:48:59 -0800 | |
---|---|---|
committer | 2018-03-10 06:50:28 -0800 | |
commit | 9c101404519d91db8e8dec09f9a9495eb8352f58 (patch) | |
tree | d2689acedd5ce2474ea89089aa8651be00c6a485 /src/test | |
parent | 50f99d56bb710f01524bd3f04882dada16a792c3 (diff) |
Add BuildConfiguration to ConfiguredTargetAndTarget and rename it to ConfiguredTargetAndData. We want to get BuildConfiguration out of ConfiguredTarget because it uses >800K when serialized.
PiperOrigin-RevId: 188600002
Diffstat (limited to 'src/test')
21 files changed, 88 insertions, 90 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/analysis/AspectAwareAttributeMapperTest.java b/src/test/java/com/google/devtools/build/lib/analysis/AspectAwareAttributeMapperTest.java index 04387b1562..872fe99585 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/AspectAwareAttributeMapperTest.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/AspectAwareAttributeMapperTest.java @@ -24,7 +24,7 @@ import com.google.devtools.build.lib.packages.Attribute; import com.google.devtools.build.lib.packages.BuildType; import com.google.devtools.build.lib.packages.ConfiguredAttributeMapper; import com.google.devtools.build.lib.packages.Rule; -import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndTarget; +import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndData; import com.google.devtools.build.lib.util.FileTypeSet; import org.junit.Before; import org.junit.Test; @@ -42,7 +42,7 @@ public class AspectAwareAttributeMapperTest extends BuildViewTestCase { @Before public final void createMapper() throws Exception { - ConfiguredTargetAndTarget ctat = + ConfiguredTargetAndData ctad = scratchConfiguredTargetAndTarget( "foo", "myrule", @@ -51,8 +51,8 @@ public class AspectAwareAttributeMapperTest extends BuildViewTestCase { " srcs = [':a.cc'],", " linkstatic = select({'//conditions:default': 1}))"); - RuleConfiguredTarget ct = (RuleConfiguredTarget) ctat.getConfiguredTarget(); - rule = (Rule) ctat.getTarget(); + RuleConfiguredTarget ct = (RuleConfiguredTarget) ctad.getConfiguredTarget(); + rule = (Rule) ctad.getTarget(); Attribute aspectAttr = new Attribute.Builder<Label>("fromaspect", BuildType.LABEL) .allowedFileTypes(FileTypeSet.ANY_FILE) .build(); diff --git a/src/test/java/com/google/devtools/build/lib/analysis/AspectDefinitionTest.java b/src/test/java/com/google/devtools/build/lib/analysis/AspectDefinitionTest.java index d6d0a967be..cb4662aa01 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/AspectDefinitionTest.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/AspectDefinitionTest.java @@ -33,7 +33,7 @@ import com.google.devtools.build.lib.packages.Attribute.LateBoundDefault; import com.google.devtools.build.lib.packages.BuildType; import com.google.devtools.build.lib.packages.ConfigurationFragmentPolicy.MissingFragmentPolicy; import com.google.devtools.build.lib.packages.NativeAspectClass; -import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndTarget; +import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndData; import com.google.devtools.build.lib.skylarkinterface.SkylarkModule; import com.google.devtools.build.lib.util.FileTypeSet; import org.junit.Test; @@ -60,7 +60,7 @@ public class AspectDefinitionTest { @Override public ConfiguredAspect create( - ConfiguredTargetAndTarget ctatBase, RuleContext context, AspectParameters parameters) { + ConfiguredTargetAndData ctadBase, RuleContext context, AspectParameters parameters) { throw new IllegalStateException(); } diff --git a/src/test/java/com/google/devtools/build/lib/analysis/AspectTest.java b/src/test/java/com/google/devtools/build/lib/analysis/AspectTest.java index a3cb103758..9ec6185da5 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/AspectTest.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/AspectTest.java @@ -45,7 +45,7 @@ import com.google.devtools.build.lib.packages.AspectParameters; import com.google.devtools.build.lib.packages.Attribute.LateBoundDefault; import com.google.devtools.build.lib.packages.NativeAspectClass; import com.google.devtools.build.lib.skyframe.AspectValue; -import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndTarget; +import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndData; import com.google.devtools.build.lib.testutil.TestConstants; import com.google.devtools.build.lib.vfs.ModifiedFileSet; import com.google.devtools.build.lib.vfs.Root; @@ -437,7 +437,7 @@ public class AspectTest extends AnalysisTestCase { @Override public ConfiguredAspect create( - ConfiguredTargetAndTarget ctatBase, RuleContext ruleContext, AspectParameters parameters) + ConfiguredTargetAndData ctadBase, RuleContext ruleContext, AspectParameters parameters) throws InterruptedException { Object lateBoundPrereq = ruleContext.getPrerequisite(":late", TARGET); return new ConfiguredAspect.Builder(this, parameters, ruleContext) @@ -507,7 +507,7 @@ public class AspectTest extends AnalysisTestCase { @Override public ConfiguredAspect create( - ConfiguredTargetAndTarget ctatBase, RuleContext ruleContext, AspectParameters parameters) + ConfiguredTargetAndData ctadBase, RuleContext ruleContext, AspectParameters parameters) throws InterruptedException { ruleContext.registerAction(new NullAction(ruleContext.createOutputArtifact())); return new ConfiguredAspect.Builder(this, parameters, ruleContext).build(); diff --git a/src/test/java/com/google/devtools/build/lib/analysis/BuildViewTest.java b/src/test/java/com/google/devtools/build/lib/analysis/BuildViewTest.java index 11c6c92497..8ffa3cea0d 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/BuildViewTest.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/BuildViewTest.java @@ -44,7 +44,7 @@ import com.google.devtools.build.lib.events.NullEventHandler; import com.google.devtools.build.lib.events.OutputFilter.RegexOutputFilter; import com.google.devtools.build.lib.packages.BuildType; import com.google.devtools.build.lib.packages.Rule; -import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndTarget; +import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndData; import com.google.devtools.build.lib.testutil.Suite; import com.google.devtools.build.lib.testutil.TestConstants; import com.google.devtools.build.lib.testutil.TestSpec; @@ -92,7 +92,7 @@ public class BuildViewTest extends BuildViewTestBase { Rule ruleTarget = (Rule) getTarget("//pkg:foo"); assertThat(ruleTarget.getRuleClass()).isEqualTo("genrule"); - ConfiguredTargetAndTarget ruleCTAT = getConfiguredTargetAndTarget("//pkg:foo"); + ConfiguredTargetAndData ruleCTAT = getConfiguredTargetAndTarget("//pkg:foo"); assertThat(ruleCTAT.getTarget()).isSameAs(ruleTarget); } @@ -116,9 +116,9 @@ public class BuildViewTest extends BuildViewTestBase { //scratch.file("tests/small_test_1.py"); update("//tests:smallTests"); - ConfiguredTargetAndTarget test1 = getConfiguredTargetAndTarget("//tests:small_test_1"); - ConfiguredTargetAndTarget test2 = getConfiguredTargetAndTarget("//tests:small_test_2"); - ConfiguredTargetAndTarget suite = getConfiguredTargetAndTarget("//tests:smallTests"); + ConfiguredTargetAndData test1 = getConfiguredTargetAndTarget("//tests:small_test_1"); + ConfiguredTargetAndData test2 = getConfiguredTargetAndTarget("//tests:small_test_2"); + ConfiguredTargetAndData suite = getConfiguredTargetAndTarget("//tests:smallTests"); ConfiguredTarget test1CT = test1.getConfiguredTarget(); ConfiguredTarget test2CT = test2.getConfiguredTarget(); diff --git a/src/test/java/com/google/devtools/build/lib/analysis/ConfigurableAttributesTest.java b/src/test/java/com/google/devtools/build/lib/analysis/ConfigurableAttributesTest.java index 6b39969963..97769f98a7 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/ConfigurableAttributesTest.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/ConfigurableAttributesTest.java @@ -29,7 +29,7 @@ import com.google.devtools.build.lib.packages.Attribute.ComputedDefault; import com.google.devtools.build.lib.packages.AttributeMap; import com.google.devtools.build.lib.packages.BuildType; import com.google.devtools.build.lib.packages.NoSuchTargetException; -import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndTarget; +import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndData; import com.google.devtools.build.lib.syntax.Type; import com.google.devtools.build.lib.testutil.TestRuleClassProvider; import com.google.devtools.build.lib.util.FileTypeSet; @@ -434,7 +434,7 @@ public class ConfigurableAttributesTest extends BuildViewTestCase { // Configuration a: useConfiguration("--test_arg=a"); - ConfiguredTargetAndTarget binary = getConfiguredTargetAndTarget("//test:the_rule"); + ConfiguredTargetAndData binary = getConfiguredTargetAndTarget("//test:the_rule"); AttributeMap attributes = getMapperFromConfiguredTargetAndTarget(binary); assertThat(attributes.get("$computed_attr", Type.STRING)).isEqualTo("a2"); @@ -1080,8 +1080,8 @@ public class ConfigurableAttributesTest extends BuildViewTestCase { " }))"); useConfiguration("--test_arg=a"); - ConfiguredTargetAndTarget ctat = getConfiguredTargetAndTarget("//srctest:gen"); - AttributeMap attributes = getMapperFromConfiguredTargetAndTarget(ctat); + ConfiguredTargetAndData ctad = getConfiguredTargetAndTarget("//srctest:gen"); + AttributeMap attributes = getMapperFromConfiguredTargetAndTarget(ctad); assertThat(attributes.get("srcs", BuildType.LABEL_LIST)).isEmpty(); } @@ -1099,8 +1099,8 @@ public class ConfigurableAttributesTest extends BuildViewTestCase { " boolean_attr = 1)"); useConfiguration("--test_arg=a"); - ConfiguredTargetAndTarget ctat = getConfiguredTargetAndTarget("//foo:rule"); - AttributeMap attributes = getMapperFromConfiguredTargetAndTarget(ctat); + ConfiguredTargetAndData ctad = getConfiguredTargetAndTarget("//foo:rule"); + AttributeMap attributes = getMapperFromConfiguredTargetAndTarget(ctad); assertThat(attributes.get("dep", BuildType.LABEL)).isEqualTo( Label.parseAbsolute("//foo:default")); } diff --git a/src/test/java/com/google/devtools/build/lib/analysis/ConfiguredAttributeMapperTest.java b/src/test/java/com/google/devtools/build/lib/analysis/ConfiguredAttributeMapperTest.java index 9208bb95ca..10f01718d1 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/ConfiguredAttributeMapperTest.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/ConfiguredAttributeMapperTest.java @@ -22,7 +22,7 @@ import com.google.devtools.build.lib.packages.Attribute; import com.google.devtools.build.lib.packages.AttributeMap; import com.google.devtools.build.lib.packages.BuildType; import com.google.devtools.build.lib.packages.ConfiguredAttributeMapper; -import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndTarget; +import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndData; import com.google.devtools.build.lib.syntax.Type; import java.util.ArrayList; import java.util.List; @@ -46,8 +46,8 @@ public class ConfiguredAttributeMapperTest extends BuildViewTestCase { * Returns a ConfiguredAttributeMapper bound to the given rule with the target configuration. */ private ConfiguredAttributeMapper getMapper(String label) throws Exception { - ConfiguredTargetAndTarget ctat = getConfiguredTargetAndTarget(label); - return getMapperFromConfiguredTargetAndTarget(ctat); + ConfiguredTargetAndData ctad = getConfiguredTargetAndTarget(label); + return getMapperFromConfiguredTargetAndTarget(ctad); } private void writeConfigRules() throws Exception { diff --git a/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestCase.java b/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestCase.java index 6e1c0634a7..2b4cdbb7b0 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestCase.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestCase.java @@ -58,7 +58,7 @@ import com.google.devtools.build.lib.rules.repository.RepositoryDelegatorFunctio import com.google.devtools.build.lib.runtime.KeepGoingOption; import com.google.devtools.build.lib.runtime.LoadingPhaseThreadsOption; import com.google.devtools.build.lib.skyframe.BazelSkyframeExecutorConstants; -import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndTarget; +import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndData; import com.google.devtools.build.lib.skyframe.ConfiguredTargetKey; import com.google.devtools.build.lib.skyframe.PrecomputedValue; import com.google.devtools.build.lib.skyframe.SequencedSkyframeExecutor; @@ -390,12 +390,12 @@ public abstract class AnalysisTestCase extends FoundationTestCase { return update(new EventBus(), defaultFlags(), aspects, labels); } - protected ConfiguredTargetAndTarget getConfiguredTargetAndTarget(String label) + protected ConfiguredTargetAndData getConfiguredTargetAndTarget(String label) throws InterruptedException { return getConfiguredTargetAndTarget(label, getTargetConfiguration()); } - protected ConfiguredTargetAndTarget getConfiguredTargetAndTarget( + protected ConfiguredTargetAndData getConfiguredTargetAndTarget( String label, BuildConfiguration config) { ensureUpdateWasCalled(); Label parsedLabel; diff --git a/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java b/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java index e3f69f50d6..a60b3ecdbe 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java @@ -124,7 +124,7 @@ import com.google.devtools.build.lib.rules.repository.RepositoryDelegatorFunctio import com.google.devtools.build.lib.skyframe.AspectValue; import com.google.devtools.build.lib.skyframe.BazelSkyframeExecutorConstants; import com.google.devtools.build.lib.skyframe.BuildConfigurationValue; -import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndTarget; +import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndData; import com.google.devtools.build.lib.skyframe.ConfiguredTargetKey; import com.google.devtools.build.lib.skyframe.DiffAwareness; import com.google.devtools.build.lib.skyframe.LegacyLoadingPhaseRunner; @@ -744,20 +744,19 @@ public abstract class BuildViewTestCase extends FoundationTestCase { } /** - * Returns a ConfiguredTargetAndTarget for the specified label, using the given build - * configuration. + * Returns a ConfiguredTargetAndData for the specified label, using the given build configuration. */ - protected ConfiguredTargetAndTarget getConfiguredTargetAndTarget( + protected ConfiguredTargetAndData getConfiguredTargetAndTarget( Label label, BuildConfiguration config) { return view.getConfiguredTargetAndTargetForTesting(reporter, label, config); } /** - * Returns the ConfiguredTargetAndTarget for the specified label. If the label corresponds to a + * Returns the ConfiguredTargetAndData for the specified label. If the label corresponds to a * target with a top-level configuration transition, that transition is applied to the given - * config in the ConfiguredTargetAndTarget's ConfiguredTarget. + * config in the ConfiguredTargetAndData's ConfiguredTarget. */ - public ConfiguredTargetAndTarget getConfiguredTargetAndTarget(String label) + public ConfiguredTargetAndData getConfiguredTargetAndTarget(String label) throws LabelSyntaxException { return getConfiguredTargetAndTarget(Label.parseAbsolute(label), targetConfig); } @@ -836,9 +835,9 @@ public abstract class BuildViewTestCase extends FoundationTestCase { protected ConfiguredTarget scratchConfiguredTarget( String packageName, String ruleName, BuildConfiguration config, String... lines) throws IOException, Exception { - ConfiguredTargetAndTarget ctat = + ConfiguredTargetAndData ctad = scratchConfiguredTargetAndTarget(packageName, ruleName, config, lines); - return ctat == null ? null : ctat.getConfiguredTarget(); + return ctad == null ? null : ctad.getConfiguredTarget(); } /** @@ -850,7 +849,7 @@ public abstract class BuildViewTestCase extends FoundationTestCase { * @return the configured tatarget and target instance for the created rule. * @throws Exception */ - protected ConfiguredTargetAndTarget scratchConfiguredTargetAndTarget( + protected ConfiguredTargetAndData scratchConfiguredTargetAndTarget( String packageName, String rulename, String... lines) throws Exception { return scratchConfiguredTargetAndTarget(packageName, rulename, targetConfig, lines); } @@ -862,11 +861,11 @@ public abstract class BuildViewTestCase extends FoundationTestCase { * @param ruleName the name of the rule. * @param config the configuration to use to construct the configured rule. * @param lines the text of the rule. - * @return the ConfiguredTargetAndTarget instance for the created rule. + * @return the ConfiguredTargetAndData instance for the created rule. * @throws IOException * @throws Exception */ - protected ConfiguredTargetAndTarget scratchConfiguredTargetAndTarget( + protected ConfiguredTargetAndData scratchConfiguredTargetAndTarget( String packageName, String ruleName, BuildConfiguration config, String... lines) throws Exception { Target rule = scratchRule(packageName, ruleName, lines); @@ -1344,10 +1343,10 @@ public abstract class BuildViewTestCase extends FoundationTestCase { } protected static ConfiguredAttributeMapper getMapperFromConfiguredTargetAndTarget( - ConfiguredTargetAndTarget ctat) { + ConfiguredTargetAndData ctad) { return ConfiguredAttributeMapper.of( - (Rule) ctat.getTarget(), - ((RuleConfiguredTarget) ctat.getConfiguredTarget()).getConfigConditions()); + (Rule) ctad.getTarget(), + ((RuleConfiguredTarget) ctad.getConfiguredTarget()).getConfigConditions()); } public static Label makeLabel(String label) { @@ -1580,13 +1579,13 @@ public abstract class BuildViewTestCase extends FoundationTestCase { * Returns an attribute value retriever for the given rule for the target configuration. */ protected AttributeMap attributes(RuleConfiguredTarget ct) { - ConfiguredTargetAndTarget ctat; + ConfiguredTargetAndData ctad; try { - ctat = getConfiguredTargetAndTarget(ct.getLabel().toString()); + ctad = getConfiguredTargetAndTarget(ct.getLabel().toString()); } catch (LabelSyntaxException e) { throw new RuntimeException(e); } - return getMapperFromConfiguredTargetAndTarget(ctat); + return getMapperFromConfiguredTargetAndTarget(ctad); } protected AttributeMap attributes(ConfiguredTarget rule) { diff --git a/src/test/java/com/google/devtools/build/lib/analysis/util/TestAspects.java b/src/test/java/com/google/devtools/build/lib/analysis/util/TestAspects.java index 1f27af4414..cebf5db59b 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/util/TestAspects.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/util/TestAspects.java @@ -50,7 +50,7 @@ import com.google.devtools.build.lib.packages.NativeAspectClass; import com.google.devtools.build.lib.packages.Rule; import com.google.devtools.build.lib.packages.SkylarkProviderIdentifier; import com.google.devtools.build.lib.rules.java.JavaConfiguration; -import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndTarget; +import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndData; import com.google.devtools.build.lib.syntax.Type; import com.google.devtools.build.lib.util.FileTypeSet; import java.util.List; @@ -228,7 +228,7 @@ public class TestAspects { implements ConfiguredAspectFactory { @Override public ConfiguredAspect create( - ConfiguredTargetAndTarget ctatBase, RuleContext ruleContext, AspectParameters parameters) { + ConfiguredTargetAndData ctadBase, RuleContext ruleContext, AspectParameters parameters) { String information = parameters.isEmpty() ? "" : " data " + Iterables.getFirst(parameters.getAttribute("baz"), null); @@ -274,7 +274,7 @@ public class TestAspects { @Override public ConfiguredAspect create( - ConfiguredTargetAndTarget ctatBase, RuleContext ruleContext, AspectParameters parameters) { + ConfiguredTargetAndData ctadBase, RuleContext ruleContext, AspectParameters parameters) { return new ConfiguredAspect.Builder(this, parameters, ruleContext) .addProvider(new FooProvider()) .build(); @@ -293,7 +293,7 @@ public class TestAspects { @Override public ConfiguredAspect create( - ConfiguredTargetAndTarget ctatBase, RuleContext ruleContext, AspectParameters parameters) { + ConfiguredTargetAndData ctadBase, RuleContext ruleContext, AspectParameters parameters) { return new ConfiguredAspect.Builder(this, parameters, ruleContext) .addProvider(new BarProvider()) .build(); @@ -428,7 +428,7 @@ public class TestAspects { @Override public ConfiguredAspect create( - ConfiguredTargetAndTarget ctatBase, RuleContext ruleContext, AspectParameters parameters) { + ConfiguredTargetAndData ctadBase, RuleContext ruleContext, AspectParameters parameters) { StringBuilder information = new StringBuilder("aspect " + ruleContext.getLabel()); if (!parameters.isEmpty()) { information.append(" data " + Iterables.getFirst(parameters.getAttribute("baz"), null)); @@ -475,8 +475,8 @@ public class TestAspects { @Override public ConfiguredAspect create( - ConfiguredTargetAndTarget ctatBase, RuleContext ruleContext, AspectParameters parameters) { - ruleContext.ruleWarning("Aspect warning on " + ctatBase.getTarget().getLabel()); + ConfiguredTargetAndData ctadBase, RuleContext ruleContext, AspectParameters parameters) { + ruleContext.ruleWarning("Aspect warning on " + ctadBase.getTarget().getLabel()); return new ConfiguredAspect.Builder(this, parameters, ruleContext).build(); } @@ -500,7 +500,7 @@ public class TestAspects { @Override public ConfiguredAspect create( - ConfiguredTargetAndTarget ctatBase, RuleContext ruleContext, AspectParameters parameters) { + ConfiguredTargetAndData ctadBase, RuleContext ruleContext, AspectParameters parameters) { ruleContext.ruleError("Aspect error"); return null; } @@ -530,7 +530,7 @@ public class TestAspects { @Override public ConfiguredAspect create( - ConfiguredTargetAndTarget ctatBase, RuleContext context, AspectParameters parameters) + ConfiguredTargetAndData ctadBase, RuleContext context, AspectParameters parameters) throws InterruptedException { return new ConfiguredAspect.Builder(this, parameters, context).build(); } @@ -776,10 +776,10 @@ public class TestAspects { @Override public ConfiguredAspect create( - ConfiguredTargetAndTarget ctatBase, RuleContext context, AspectParameters parameters) + ConfiguredTargetAndData ctadBase, RuleContext context, AspectParameters parameters) throws InterruptedException { return ConfiguredAspect.builder(this, parameters, context) - .addProvider(Provider.class, new Provider(ctatBase.getConfiguredTarget().getLabel())) + .addProvider(Provider.class, new Provider(ctadBase.getConfiguredTarget().getLabel())) .build(); } } diff --git a/src/test/java/com/google/devtools/build/lib/bazel/repository/skylark/SkylarkRepositoryIntegrationTest.java b/src/test/java/com/google/devtools/build/lib/bazel/repository/skylark/SkylarkRepositoryIntegrationTest.java index 7fa018d49c..072ba2e9ac 100644 --- a/src/test/java/com/google/devtools/build/lib/bazel/repository/skylark/SkylarkRepositoryIntegrationTest.java +++ b/src/test/java/com/google/devtools/build/lib/bazel/repository/skylark/SkylarkRepositoryIntegrationTest.java @@ -31,7 +31,7 @@ import com.google.devtools.build.lib.rules.repository.LocalRepositoryRule; import com.google.devtools.build.lib.rules.repository.RepositoryDelegatorFunction; import com.google.devtools.build.lib.rules.repository.RepositoryFunction; import com.google.devtools.build.lib.rules.repository.RepositoryLoaderFunction; -import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndTarget; +import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndData; import com.google.devtools.build.lib.skyframe.SkyFunctions; import com.google.devtools.build.lib.testutil.TestRuleClassProvider; import com.google.devtools.build.skyframe.SkyFunction; @@ -142,7 +142,7 @@ public class SkylarkRepositoryIntegrationTest extends BuildViewTestCase { .add("repo(name='foo', path='/repo2')") .build()); invalidatePackages(); - ConfiguredTargetAndTarget target = getConfiguredTargetAndTarget("@foo//:bar"); + ConfiguredTargetAndData target = getConfiguredTargetAndTarget("@foo//:bar"); Object path = target.getTarget().getAssociatedRule().getAttributeContainer().getAttr("path"); assertThat(path).isEqualTo("foo"); } @@ -170,7 +170,7 @@ public class SkylarkRepositoryIntegrationTest extends BuildViewTestCase { .add("repo(name='foo')") .build()); invalidatePackages(); - ConfiguredTargetAndTarget target = getConfiguredTargetAndTarget("@foo//:bar"); + ConfiguredTargetAndData target = getConfiguredTargetAndTarget("@foo//:bar"); Object path = target.getTarget().getAssociatedRule().getAttributeContainer().getAttr("path"); assertThat(path).isEqualTo("foo"); } @@ -199,7 +199,7 @@ public class SkylarkRepositoryIntegrationTest extends BuildViewTestCase { .add("repo(name='foo')") .build()); invalidatePackages(); - ConfiguredTargetAndTarget target = getConfiguredTargetAndTarget("@foo//:bar"); + ConfiguredTargetAndData target = getConfiguredTargetAndTarget("@foo//:bar"); Object path = target.getTarget().getAssociatedRule().getAttributeContainer().getAttr("path"); assertThat(path).isEqualTo("foo"); } @@ -229,7 +229,7 @@ public class SkylarkRepositoryIntegrationTest extends BuildViewTestCase { .add("repo(name='foobar')") .build()); invalidatePackages(); - ConfiguredTargetAndTarget target = getConfiguredTargetAndTarget("@foobar//:bar"); + ConfiguredTargetAndData target = getConfiguredTargetAndTarget("@foobar//:bar"); Object path = target.getTarget().getAssociatedRule().getAttributeContainer().getAttr("path"); assertThat(path).isEqualTo("foobar"); } diff --git a/src/test/java/com/google/devtools/build/lib/bazel/rules/android/AndroidNdkRepositoryTest.java b/src/test/java/com/google/devtools/build/lib/bazel/rules/android/AndroidNdkRepositoryTest.java index c04f0102fc..dcdea30d08 100644 --- a/src/test/java/com/google/devtools/build/lib/bazel/rules/android/AndroidNdkRepositoryTest.java +++ b/src/test/java/com/google/devtools/build/lib/bazel/rules/android/AndroidNdkRepositoryTest.java @@ -23,7 +23,7 @@ import com.google.devtools.build.lib.analysis.util.BuildViewTestCase; import com.google.devtools.build.lib.collect.nestedset.NestedSet; import com.google.devtools.build.lib.packages.AttributeContainer; import com.google.devtools.build.lib.packages.BuildFileNotFoundException; -import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndTarget; +import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndData; import com.google.devtools.build.lib.testutil.MoreAsserts; import com.google.devtools.build.lib.testutil.TestRuleClassProvider; import com.google.devtools.build.lib.vfs.FileSystemUtils; @@ -170,8 +170,7 @@ public class AndroidNdkRepositoryTest extends BuildViewTestCase { ")"); invalidatePackages(); - ConfiguredTargetAndTarget cpufeatures = - getConfiguredTargetAndTarget("@androidndk//:cpufeatures"); + ConfiguredTargetAndData cpufeatures = getConfiguredTargetAndTarget("@androidndk//:cpufeatures"); assertThat(cpufeatures).isNotNull(); AttributeContainer attributes = cpufeatures.getTarget().getAssociatedRule().getAttributeContainer(); diff --git a/src/test/java/com/google/devtools/build/lib/bazel/rules/android/AndroidSdkRepositoryTest.java b/src/test/java/com/google/devtools/build/lib/bazel/rules/android/AndroidSdkRepositoryTest.java index b1085bfcf3..ee1810f724 100644 --- a/src/test/java/com/google/devtools/build/lib/bazel/rules/android/AndroidSdkRepositoryTest.java +++ b/src/test/java/com/google/devtools/build/lib/bazel/rules/android/AndroidSdkRepositoryTest.java @@ -23,7 +23,7 @@ import com.google.devtools.build.lib.analysis.util.BuildViewTestCase; import com.google.devtools.build.lib.packages.BuildFileNotFoundException; import com.google.devtools.build.lib.packages.util.ResourceLoader; import com.google.devtools.build.lib.rules.android.AndroidSdkProvider; -import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndTarget; +import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndData; import com.google.devtools.build.lib.vfs.FileSystemUtils; import org.junit.Before; import org.junit.Test; @@ -92,7 +92,7 @@ public class AndroidSdkRepositoryTest extends BuildViewTestCase { ")"); invalidatePackages(); - ConfiguredTargetAndTarget aarImportTarget = + ConfiguredTargetAndData aarImportTarget = getConfiguredTargetAndTarget("@androidsdk//com.google.android:foo-1.0.0"); assertThat(aarImportTarget).isNotNull(); assertThat(aarImportTarget.getTarget().getAssociatedRule().getRuleClass()) diff --git a/src/test/java/com/google/devtools/build/lib/packages/ExternalPackageTest.java b/src/test/java/com/google/devtools/build/lib/packages/ExternalPackageTest.java index da31a7a049..26cf80cde9 100644 --- a/src/test/java/com/google/devtools/build/lib/packages/ExternalPackageTest.java +++ b/src/test/java/com/google/devtools/build/lib/packages/ExternalPackageTest.java @@ -17,7 +17,7 @@ import static com.google.common.truth.Truth.assertThat; import com.google.devtools.build.lib.analysis.util.BuildViewTestCase; import com.google.devtools.build.lib.cmdline.Label; -import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndTarget; +import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndData; import com.google.devtools.build.lib.vfs.FileSystemUtils; import com.google.devtools.build.lib.vfs.Path; import org.junit.Before; @@ -101,9 +101,9 @@ public class ExternalPackageTest extends BuildViewTestCase { "java_library(name = 'c', srcs = [])"); invalidatePackages(); useConfiguration("--define", "foo=bar"); - ConfiguredTargetAndTarget ctat = getConfiguredTargetAndTarget("//:a"); + ConfiguredTargetAndData ctad = getConfiguredTargetAndTarget("//:a"); ConfiguredAttributeMapper configuredAttributeMapper = - getMapperFromConfiguredTargetAndTarget(ctat); + getMapperFromConfiguredTargetAndTarget(ctad); assertThat(configuredAttributeMapper.get("runtime_deps", BuildType.LABEL_LIST)) .containsExactly(Label.parseAbsolute("//:b")); } diff --git a/src/test/java/com/google/devtools/build/lib/rules/android/AndroidBinaryTest.java b/src/test/java/com/google/devtools/build/lib/rules/android/AndroidBinaryTest.java index 1b5a01cc1d..d685a464bd 100644 --- a/src/test/java/com/google/devtools/build/lib/rules/android/AndroidBinaryTest.java +++ b/src/test/java/com/google/devtools/build/lib/rules/android/AndroidBinaryTest.java @@ -51,7 +51,7 @@ import com.google.devtools.build.lib.rules.java.JavaCompilationArgsProvider; import com.google.devtools.build.lib.rules.java.JavaCompileAction; import com.google.devtools.build.lib.rules.java.JavaInfo; import com.google.devtools.build.lib.rules.java.JavaSemantics; -import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndTarget; +import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndData; import com.google.devtools.build.lib.testutil.MoreAsserts; import com.google.devtools.build.lib.util.FileType; import com.google.devtools.build.lib.vfs.FileSystemUtils; @@ -2045,7 +2045,7 @@ public class AndroidBinaryTest extends AndroidBuildViewTestCase { "<resources><string name = 'lib_string'>Libs!</string></resources>"); scratch.file("java/r/android/res/values/strings.xml", "<resources><string name = 'hello'>Hello Android!</string></resources>"); - ConfiguredTargetAndTarget binary = getConfiguredTargetAndTarget("//java/r/android:r"); + ConfiguredTargetAndData binary = getConfiguredTargetAndTarget("//java/r/android:r"); Artifact jar = getResourceClassJar(binary); assertThat(getGeneratingAction(jar).getMnemonic()).isEqualTo("RClassGenerator"); List<String> args = getGeneratingSpawnActionArgs(jar); diff --git a/src/test/java/com/google/devtools/build/lib/rules/android/AndroidBuildViewTestCase.java b/src/test/java/com/google/devtools/build/lib/rules/android/AndroidBuildViewTestCase.java index 657ecacd9d..6deb85f35c 100644 --- a/src/test/java/com/google/devtools/build/lib/rules/android/AndroidBuildViewTestCase.java +++ b/src/test/java/com/google/devtools/build/lib/rules/android/AndroidBuildViewTestCase.java @@ -39,7 +39,7 @@ import com.google.devtools.build.lib.rules.android.deployinfo.AndroidDeployInfoO import com.google.devtools.build.lib.rules.java.JavaCompileAction; import com.google.devtools.build.lib.rules.java.JavaInfo; import com.google.devtools.build.lib.rules.java.JavaRuleOutputJarsProvider; -import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndTarget; +import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndData; import java.io.IOException; import java.util.ArrayList; import java.util.Arrays; @@ -138,7 +138,7 @@ public abstract class AndroidBuildViewTestCase extends BuildViewTestCase { transitive ? info.getTransitiveAndroidResources() : info.getDirectAndroidResources()); } - protected Artifact getResourceClassJar(final ConfiguredTargetAndTarget target) { + protected Artifact getResourceClassJar(final ConfiguredTargetAndData target) { JavaRuleOutputJarsProvider jarProvider = JavaInfo.getProvider(JavaRuleOutputJarsProvider.class, target.getConfiguredTarget()); assertThat(jarProvider).isNotNull(); diff --git a/src/test/java/com/google/devtools/build/lib/rules/android/AndroidInstrumentationTestTest.java b/src/test/java/com/google/devtools/build/lib/rules/android/AndroidInstrumentationTestTest.java index f50823be3a..da6d287447 100644 --- a/src/test/java/com/google/devtools/build/lib/rules/android/AndroidInstrumentationTestTest.java +++ b/src/test/java/com/google/devtools/build/lib/rules/android/AndroidInstrumentationTestTest.java @@ -25,7 +25,7 @@ import com.google.devtools.build.lib.analysis.FilesToRunProvider; import com.google.devtools.build.lib.analysis.RunfilesProvider; import com.google.devtools.build.lib.analysis.actions.TemplateExpansionAction; import com.google.devtools.build.lib.collect.nestedset.NestedSet; -import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndTarget; +import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndData; import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; @@ -118,7 +118,7 @@ public class AndroidInstrumentationTestTest extends AndroidBuildViewTestCase { @Test public void testTestExecutableRunfiles() throws Exception { - ConfiguredTargetAndTarget androidInstrumentationTest = + ConfiguredTargetAndData androidInstrumentationTest = getConfiguredTargetAndTarget("//javatests/com/app/ait"); NestedSet<Artifact> runfiles = androidInstrumentationTest diff --git a/src/test/java/com/google/devtools/build/lib/rules/apple/XcodeConfigTest.java b/src/test/java/com/google/devtools/build/lib/rules/apple/XcodeConfigTest.java index a0880c5c5b..366522783a 100644 --- a/src/test/java/com/google/devtools/build/lib/rules/apple/XcodeConfigTest.java +++ b/src/test/java/com/google/devtools/build/lib/rules/apple/XcodeConfigTest.java @@ -20,7 +20,7 @@ import com.google.common.collect.ImmutableMap; import com.google.devtools.build.lib.analysis.ConfiguredTarget; import com.google.devtools.build.lib.analysis.util.BuildViewTestCase; import com.google.devtools.build.lib.packages.ConfiguredAttributeMapper; -import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndTarget; +import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndData; import com.google.devtools.build.lib.syntax.Type; import org.junit.Test; import org.junit.runner.RunWith; @@ -805,7 +805,7 @@ public class XcodeConfigTest extends BuildViewTestCase { * Returns a ConfiguredAttributeMapper bound to the given rule with the target configuration. */ private ConfiguredAttributeMapper getMapper(String label) throws Exception { - ConfiguredTargetAndTarget ctat = getConfiguredTargetAndTarget(label); - return getMapperFromConfiguredTargetAndTarget(ctat); + ConfiguredTargetAndData ctad = getConfiguredTargetAndTarget(label); + return getMapperFromConfiguredTargetAndTarget(ctad); } } diff --git a/src/test/java/com/google/devtools/build/lib/rules/config/ConfigFeatureFlagTest.java b/src/test/java/com/google/devtools/build/lib/rules/config/ConfigFeatureFlagTest.java index 910e1f7c07..f9cb224efb 100644 --- a/src/test/java/com/google/devtools/build/lib/rules/config/ConfigFeatureFlagTest.java +++ b/src/test/java/com/google/devtools/build/lib/rules/config/ConfigFeatureFlagTest.java @@ -23,7 +23,7 @@ import com.google.devtools.build.lib.analysis.ConfiguredRuleClassProvider; import com.google.devtools.build.lib.analysis.ConfiguredTarget; import com.google.devtools.build.lib.analysis.skylark.SkylarkRuleContext; import com.google.devtools.build.lib.packages.ConfiguredAttributeMapper; -import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndTarget; +import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndData; import com.google.devtools.build.lib.skylark.util.SkylarkTestCase; import com.google.devtools.build.lib.syntax.Type; import com.google.devtools.build.lib.testutil.TestRuleClassProvider; @@ -133,8 +133,8 @@ public final class ConfigFeatureFlagTest extends SkylarkTestCase { " '//conditions:default': 'error'", " }))"); - ConfiguredTargetAndTarget ctat = getConfiguredTargetAndTarget("//test:gen"); - ConfiguredAttributeMapper attributeMapper = getMapperFromConfiguredTargetAndTarget(ctat); + ConfiguredTargetAndData ctad = getConfiguredTargetAndTarget("//test:gen"); + ConfiguredAttributeMapper attributeMapper = getMapperFromConfiguredTargetAndTarget(ctad); assertThat(attributeMapper.get("cmd", Type.STRING)).isEqualTo("hello"); } diff --git a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java index 6722d2161c..d249fb1f84 100644 --- a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java +++ b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java @@ -35,7 +35,7 @@ import com.google.devtools.build.lib.analysis.util.AnalysisMock; import com.google.devtools.build.lib.analysis.util.BuildViewTestCase; import com.google.devtools.build.lib.packages.ImplicitOutputsFunction; import com.google.devtools.build.lib.packages.util.MockCcSupport; -import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndTarget; +import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndData; import com.google.devtools.build.lib.testutil.TestRuleClassProvider; import com.google.devtools.build.lib.util.FileType; import com.google.devtools.build.lib.vfs.PathFragment; @@ -1135,7 +1135,7 @@ public class CcLibraryConfiguredTargetTest extends BuildViewTestCase { public void addOnlyStaticLibraryToFilesToBuildWhenWrappingIffImplicitOutput() throws Exception { // This shared library has the same name as the archive generated by this rule, so it should // override said archive. However, said archive should still be put in files to build. - ConfiguredTargetAndTarget target = + ConfiguredTargetAndData target = scratchConfiguredTargetAndTarget("a", "b", "cc_library(name = 'b', srcs = ['libb.so'])"); if (target.getTarget().getAssociatedRule().getImplicitOutputsFunction() diff --git a/src/test/java/com/google/devtools/build/lib/skyframe/ConfigurationsForTargetsTest.java b/src/test/java/com/google/devtools/build/lib/skyframe/ConfigurationsForTargetsTest.java index bc0d3ec083..f1f4b367a1 100644 --- a/src/test/java/com/google/devtools/build/lib/skyframe/ConfigurationsForTargetsTest.java +++ b/src/test/java/com/google/devtools/build/lib/skyframe/ConfigurationsForTargetsTest.java @@ -119,9 +119,9 @@ public class ConfigurationsForTargetsTest extends AnalysisTestCase { * deps of given target. */ static class Value implements SkyValue { - OrderedSetMultimap<Attribute, ConfiguredTargetAndTarget> depMap; + OrderedSetMultimap<Attribute, ConfiguredTargetAndData> depMap; - Value(OrderedSetMultimap<Attribute, ConfiguredTargetAndTarget> depMap) { + Value(OrderedSetMultimap<Attribute, ConfiguredTargetAndData> depMap) { this.depMap = depMap; } } @@ -130,7 +130,7 @@ public class ConfigurationsForTargetsTest extends AnalysisTestCase { public SkyValue compute(SkyKey skyKey, Environment env) throws EvalException, InterruptedException { try { - OrderedSetMultimap<Attribute, ConfiguredTargetAndTarget> depMap = + OrderedSetMultimap<Attribute, ConfiguredTargetAndData> depMap = ConfiguredTargetFunction.computeDependencies( env, new SkyframeDependencyResolver(env), @@ -209,7 +209,7 @@ public class ConfigurationsForTargetsTest extends AnalysisTestCase { * Returns the configured deps for a given target, assuming the target uses the target * configuration. */ - private Multimap<Attribute, ConfiguredTargetAndTarget> getConfiguredDeps(String targetLabel) + private Multimap<Attribute, ConfiguredTargetAndData> getConfiguredDeps(String targetLabel) throws Exception { update(targetLabel); SkyKey key = ComputeDependenciesFunction.key(getTarget(targetLabel), getTargetConfiguration()); @@ -230,12 +230,12 @@ public class ConfigurationsForTargetsTest extends AnalysisTestCase { */ protected List<ConfiguredTarget> getConfiguredDeps(String targetLabel, String attrName) throws Exception { - Multimap<Attribute, ConfiguredTargetAndTarget> allDeps = getConfiguredDeps(targetLabel); + Multimap<Attribute, ConfiguredTargetAndData> allDeps = getConfiguredDeps(targetLabel); for (Attribute attribute : allDeps.keySet()) { if (attribute.getName().equals(attrName)) { return ImmutableList.copyOf( Collections2.transform( - allDeps.get(attribute), ConfiguredTargetAndTarget::getConfiguredTarget)); + allDeps.get(attribute), ConfiguredTargetAndData::getConfiguredTarget)); } } throw new AssertionError( diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkIntegrationTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkIntegrationTest.java index d50081591a..7f6958a4c5 100644 --- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkIntegrationTest.java +++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkIntegrationTest.java @@ -39,7 +39,7 @@ import com.google.devtools.build.lib.packages.Info; import com.google.devtools.build.lib.packages.Provider; import com.google.devtools.build.lib.packages.SkylarkProvider; import com.google.devtools.build.lib.packages.SkylarkProvider.SkylarkKey; -import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndTarget; +import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndData; import com.google.devtools.build.lib.skyframe.PackageFunction; import com.google.devtools.build.lib.skyframe.SkyFunctions; import com.google.devtools.build.lib.skyframe.SkylarkImportLookupFunction; @@ -108,7 +108,7 @@ public class SkylarkIntegrationTest extends BuildViewTestCase { } private AttributeContainer getContainerForTarget(String targetName) throws Exception { - ConfiguredTargetAndTarget target = getConfiguredTargetAndTarget("//test/skylark:" + targetName); + ConfiguredTargetAndData target = getConfiguredTargetAndTarget("//test/skylark:" + targetName); return target.getTarget().getAssociatedRule().getAttributeContainer(); } |