diff options
author | 2018-03-19 20:47:37 -0700 | |
---|---|---|
committer | 2018-03-19 20:49:36 -0700 | |
commit | 755a0a10e14c4fe4c2ff3b71af9f99d5d1a924cf (patch) | |
tree | 6175f03d4c94d82fcfa226f9df38ea316f7be8d5 /src/test | |
parent | 56d1b1c3122a3d1ec111baab339631b8c42c2c31 (diff) |
Automated rollback of commit 72d28f3efc2842510a34cacd930c0204143f7412.
Fix skylark caching to properly include transitive dependencies when there is a diamond-like dependency in the loaded bzl files.
Also add guards to make sure we're not attempting to cache skylark files that transitively request a dependency that is in error.
*** Reason for rollback ***
Looking for source of non-determinism
*** Original change description ***
Automated rollback of commit 7ba939dfd5df48903929e9c14ebd0449656403e4.
*** Reason for rollback ***
Likely cause for non-determinism in skyframe
*** Original change description ***
Cache SkylarkLookupImportValues in memory so that we don't recompute them multiple times.
PiperOrigin-RevId: 189686604
Diffstat (limited to 'src/test')
-rw-r--r-- | src/test/java/com/google/devtools/build/lib/skylark/SkylarkIntegrationTest.java | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkIntegrationTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkIntegrationTest.java index a76546fd69..bfb0cbc43a 100644 --- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkIntegrationTest.java +++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkIntegrationTest.java @@ -1652,6 +1652,7 @@ public class SkylarkIntegrationTest extends BuildViewTestCase { .getSkyFunctionsForTesting(); SkylarkImportLookupFunction skylarkImportLookupFunction = new SkylarkImportLookupFunction(this.getRuleClassProvider(), this.getPackageFactory()); + skylarkImportLookupFunction.resetCache(); ((PackageFunction) skyFunctions.get(SkyFunctions.PACKAGE)) .setSkylarkImportLookupFunctionForInliningForTesting(skylarkImportLookupFunction); } |