diff options
author | 2017-08-21 12:52:41 +0200 | |
---|---|---|
committer | 2017-08-21 14:16:34 +0200 | |
commit | 375f95b16e1a8b164d2caaa4d65a4c9b4e310bd3 (patch) | |
tree | faf5464b37651fa52f76d63f060e6dd2b09dd522 /src/test | |
parent | e3684497a5a8c4bd42ff970b37c49dc70bcc3eae (diff) |
Rename some of native declared providers according to the new naming scheme.
RELNOTES: None
PiperOrigin-RevId: 165910455
Diffstat (limited to 'src/test')
12 files changed, 65 insertions, 65 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/rules/ToolchainTypeTest.java b/src/test/java/com/google/devtools/build/lib/rules/ToolchainTypeTest.java index dab0cc4b54..02e82adc0e 100644 --- a/src/test/java/com/google/devtools/build/lib/rules/ToolchainTypeTest.java +++ b/src/test/java/com/google/devtools/build/lib/rules/ToolchainTypeTest.java @@ -16,7 +16,7 @@ package com.google.devtools.build.lib.rules; import static com.google.common.truth.Truth.assertThat; import com.google.devtools.build.lib.analysis.ConfiguredTarget; -import com.google.devtools.build.lib.analysis.MakeVariableProvider; +import com.google.devtools.build.lib.analysis.MakeVariableInfo; import com.google.devtools.build.lib.analysis.util.BuildViewTestCase; import org.junit.Test; import org.junit.runner.RunWith; @@ -29,7 +29,7 @@ public class ToolchainTypeTest extends BuildViewTestCase { public void testSmoke() throws Exception { ConfiguredTarget cc = getConfiguredTarget(getRuleClassProvider().getToolsRepository() + "//tools/cpp:toolchain_type"); - assertThat(cc.get(MakeVariableProvider.SKYLARK_CONSTRUCTOR).getMakeVariables()) + assertThat(cc.get(MakeVariableInfo.PROVIDER).getMakeVariables()) .containsKey("TARGET_CPU"); } } diff --git a/src/test/java/com/google/devtools/build/lib/rules/android/AndroidDeviceTest.java b/src/test/java/com/google/devtools/build/lib/rules/android/AndroidDeviceTest.java index 7650b01f09..73f386b9b5 100644 --- a/src/test/java/com/google/devtools/build/lib/rules/android/AndroidDeviceTest.java +++ b/src/test/java/com/google/devtools/build/lib/rules/android/AndroidDeviceTest.java @@ -29,7 +29,7 @@ import com.google.devtools.build.lib.analysis.Runfiles; import com.google.devtools.build.lib.analysis.RunfilesProvider; import com.google.devtools.build.lib.analysis.actions.SpawnAction; import com.google.devtools.build.lib.analysis.actions.TemplateExpansionAction; -import com.google.devtools.build.lib.analysis.test.ExecutionInfoProvider; +import com.google.devtools.build.lib.analysis.test.ExecutionInfo; import com.google.devtools.build.lib.analysis.util.BuildViewTestCase; import java.io.IOException; import java.util.HashSet; @@ -167,10 +167,10 @@ public class AndroidDeviceTest extends BuildViewTestCase { getToolDependencyExecPathString("//tools/android/emulator:support_file1"), getToolDependencyExecPathString("//tools/android/emulator:support_file2")); - assertThat(target.get(ExecutionInfoProvider.SKYLARK_CONSTRUCTOR.getKey())).isNotNull(); - ExecutionInfoProvider executionInfoProvider = - target.get(ExecutionInfoProvider.SKYLARK_CONSTRUCTOR); - assertThat(executionInfoProvider.getExecutionInfo()).doesNotContainKey(REQUIRES_KVM); + assertThat(target.get(ExecutionInfo.PROVIDER.getKey())).isNotNull(); + ExecutionInfo executionInfo = + target.get(ExecutionInfo.PROVIDER); + assertThat(executionInfo.getExecutionInfo()).doesNotContainKey(REQUIRES_KVM); TemplateExpansionAction stubAction = (TemplateExpansionAction) getGeneratingAction( getExecutable(target)); String stubContents = stubAction.getFileContents(); @@ -227,8 +227,8 @@ public class AndroidDeviceTest extends BuildViewTestCase { assertThat(action.getExecutionInfo()) .containsEntry(REQUIRES_KVM, ""); - assertThat(target.get(ExecutionInfoProvider.SKYLARK_CONSTRUCTOR.getKey())).isNotNull(); - assertThat(target.get(ExecutionInfoProvider.SKYLARK_CONSTRUCTOR).getExecutionInfo()) + assertThat(target.get(ExecutionInfo.PROVIDER.getKey())).isNotNull(); + assertThat(target.get(ExecutionInfo.PROVIDER).getExecutionInfo()) .containsKey(REQUIRES_KVM); } diff --git a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java index 041368975a..a388e41943 100644 --- a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java +++ b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java @@ -226,7 +226,7 @@ public class CcLibraryConfiguredTargetTest extends BuildViewTestCase { ConfiguredTarget hello = getConfiguredTarget("//hello:hello"); assertThat( hello - .get(CcLinkParamsProvider.CC_LINK_PARAMS) + .get(CcLinkParamsInfo.PROVIDER) .getCcLinkParams(false, false) .getLinkopts() .isEmpty()) @@ -1149,7 +1149,7 @@ public class CcLibraryConfiguredTargetTest extends BuildViewTestCase { Iterable<Artifact> libraries = LinkerInputs.toNonSolibArtifacts( target - .get(CcLinkParamsProvider.CC_LINK_PARAMS) + .get(CcLinkParamsInfo.PROVIDER) .getCcLinkParams(true, true) .getLibraries()); assertThat(artifactsToStrings(libraries)).contains("bin a/libfoo.a"); @@ -1164,7 +1164,7 @@ public class CcLibraryConfiguredTargetTest extends BuildViewTestCase { Iterable<Artifact> libraries = LinkerInputs.toNonSolibArtifacts( target - .get(CcLinkParamsProvider.CC_LINK_PARAMS) + .get(CcLinkParamsInfo.PROVIDER) .getCcLinkParams(true, true) .getLibraries()); assertThat(artifactsToStrings(libraries)).doesNotContain("bin a/libfoo.a"); @@ -1180,7 +1180,7 @@ public class CcLibraryConfiguredTargetTest extends BuildViewTestCase { Iterable<Artifact> libraries = LinkerInputs.toNonSolibArtifacts( target - .get(CcLinkParamsProvider.CC_LINK_PARAMS) + .get(CcLinkParamsInfo.PROVIDER) .getCcLinkParams(true, true) .getLibraries()); assertThat(artifactsToStrings(libraries)).doesNotContain("src a/libfoo.so"); diff --git a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcToolchainTest.java b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcToolchainTest.java index a8939a54d1..fa12efd127 100644 --- a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcToolchainTest.java +++ b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcToolchainTest.java @@ -114,6 +114,6 @@ public class CcToolchainTest extends BuildViewTestCase { public void testToolchainAlias() throws Exception { ConfiguredTarget reference = scratchConfiguredTarget("a", "ref", "cc_toolchain_alias(name='ref')"); - assertThat(reference.get(CcToolchainProvider.SKYLARK_CONSTRUCTOR.getKey())).isNotNull(); + assertThat(reference.get(CcToolchainProvider.PROVIDER.getKey())).isNotNull(); } } diff --git a/src/test/java/com/google/devtools/build/lib/rules/cpp/CrosstoolConfigurationLoaderTest.java b/src/test/java/com/google/devtools/build/lib/rules/cpp/CrosstoolConfigurationLoaderTest.java index 0f0df4484a..f879b160b1 100644 --- a/src/test/java/com/google/devtools/build/lib/rules/cpp/CrosstoolConfigurationLoaderTest.java +++ b/src/test/java/com/google/devtools/build/lib/rules/cpp/CrosstoolConfigurationLoaderTest.java @@ -21,7 +21,7 @@ import com.google.common.base.Functions; import com.google.common.collect.ImmutableList; import com.google.common.collect.ImmutableMap; import com.google.devtools.build.lib.analysis.ConfiguredTarget; -import com.google.devtools.build.lib.analysis.MakeVariableProvider; +import com.google.devtools.build.lib.analysis.MakeVariableInfo; import com.google.devtools.build.lib.analysis.config.CompilationMode; import com.google.devtools.build.lib.analysis.config.ConfigurationEnvironment; import com.google.devtools.build.lib.analysis.config.InvalidConfigurationException; @@ -163,7 +163,7 @@ public class CrosstoolConfigurationLoaderTest extends AnalysisTestCase { private CcToolchainProvider getCcToolchainProvider(CppConfiguration cppConfiguration) throws Exception { return (CcToolchainProvider) - getCcToolchainTarget(cppConfiguration).get(ToolchainInfo.SKYLARK_CONSTRUCTOR); + getCcToolchainTarget(cppConfiguration).get(ToolchainInfo.PROVIDER); } /** @@ -491,8 +491,8 @@ public class CrosstoolConfigurationLoaderTest extends AnalysisTestCase { create(loader, "--cpu=piii", "--host_cpu=piii", "--android_cpu=", "--fat_apk_cpu="); ConfiguredTarget ccToolchainA = getCcToolchainTarget(toolchainA); CcToolchainProvider ccProviderA = - (CcToolchainProvider) ccToolchainA.get(ToolchainInfo.SKYLARK_CONSTRUCTOR); - MakeVariableProvider makeProviderA = ccToolchainA.get(MakeVariableProvider.SKYLARK_CONSTRUCTOR); + (CcToolchainProvider) ccToolchainA.get(ToolchainInfo.PROVIDER); + MakeVariableInfo makeProviderA = ccToolchainA.get(MakeVariableInfo.PROVIDER); assertThat(toolchainA.getToolchainIdentifier()).isEqualTo("toolchain-identifier-A"); assertThat(toolchainA.getHostSystemName()).isEqualTo("host-system-name-A"); assertThat(toolchainA.getTargetGnuSystemName()).isEqualTo("target-system-name-A"); diff --git a/src/test/java/com/google/devtools/build/lib/rules/java/JavaRuntimeProviderTest.java b/src/test/java/com/google/devtools/build/lib/rules/java/JavaRuntimeInfoTest.java index 750390dd5d..8b4184ff51 100644 --- a/src/test/java/com/google/devtools/build/lib/rules/java/JavaRuntimeProviderTest.java +++ b/src/test/java/com/google/devtools/build/lib/rules/java/JavaRuntimeInfoTest.java @@ -23,18 +23,18 @@ import org.junit.runner.RunWith; import org.junit.runners.JUnit4; /** - * Unit tests for {@code JavaRuntimeProvider} + * Unit tests for {@code JavaRuntimeInfo} */ @RunWith(JUnit4.class) -public class JavaRuntimeProviderTest { +public class JavaRuntimeInfoTest { @Test public void equalityIsObjectIdentity() { - JavaRuntimeProvider a = new JavaRuntimeProvider( + JavaRuntimeInfo a = new JavaRuntimeInfo( NestedSetBuilder.emptySet(Order.STABLE_ORDER), PathFragment.create(""), PathFragment.create(""), PathFragment.create("")); - JavaRuntimeProvider b = new JavaRuntimeProvider( + JavaRuntimeInfo b = new JavaRuntimeInfo( NestedSetBuilder.emptySet(Order.STABLE_ORDER), PathFragment.create(""), PathFragment.create(""), diff --git a/src/test/java/com/google/devtools/build/lib/rules/java/JavaSkylarkApiTest.java b/src/test/java/com/google/devtools/build/lib/rules/java/JavaSkylarkApiTest.java index d8387a182b..e21ef2c829 100644 --- a/src/test/java/com/google/devtools/build/lib/rules/java/JavaSkylarkApiTest.java +++ b/src/test/java/com/google/devtools/build/lib/rules/java/JavaSkylarkApiTest.java @@ -225,7 +225,7 @@ public class JavaSkylarkApiTest extends BuildViewTestCase { // Extract out information from native rule JavaCompilationArgsProvider jlJavaCompilationArgsProvider = - JavaProvider.getProvider(JavaCompilationArgsProvider.class, javaLibraryTarget); + JavaInfo.getProvider(JavaCompilationArgsProvider.class, javaLibraryTarget); NestedSet<Artifact> jlCompileJars = jlJavaCompilationArgsProvider.getJavaCompilationArgs().getCompileTimeJars(); NestedSet<Artifact> jlTransitiveRuntimeJars = @@ -295,7 +295,7 @@ public class JavaSkylarkApiTest extends BuildViewTestCase { " transitive_runtime_jars = ['libd.jar'],", ")"); ConfiguredTarget target = getConfiguredTarget("//foo:myrule"); - Info info = target.get(JavaProvider.JAVA_PROVIDER); + Info info = target.get(JavaInfo.PROVIDER); SkylarkNestedSet compileJars = (SkylarkNestedSet) info.getValue("compile_jars"); assertThat(prettyJarNames(compileJars.getSet(Artifact.class))).containsExactly("foo/liba.jar"); @@ -335,7 +335,7 @@ public class JavaSkylarkApiTest extends BuildViewTestCase { " transitive_runtime_jars = ['libd.jar'],", ")"); ConfiguredTarget target = getConfiguredTarget("//foo:myrule"); - Info info = target.get(JavaProvider.JAVA_PROVIDER); + Info info = target.get(JavaInfo.PROVIDER); SkylarkNestedSet compileJars = (SkylarkNestedSet) info.getValue("compile_jars"); assertThat(prettyJarNames(compileJars.getSet(Artifact.class))).containsExactly("foo/liba.jar"); @@ -382,7 +382,7 @@ public class JavaSkylarkApiTest extends BuildViewTestCase { ")"); ConfiguredTarget target = getConfiguredTarget("//foo:myrule"); JavaCompilationArgsProvider provider = - JavaProvider.getProvider(JavaCompilationArgsProvider.class, target); + JavaInfo.getProvider(JavaCompilationArgsProvider.class, target); assertThat(provider).isNotNull(); List<String> compileTimeJars = prettyJarNames(provider.getJavaCompilationArgs().getCompileTimeJars()); @@ -399,7 +399,7 @@ public class JavaSkylarkApiTest extends BuildViewTestCase { assertThat(transitiveRuntimeJars).containsExactly("foo/libd.jar"); JavaSourceJarsProvider sourcesProvider = - JavaProvider.getProvider(JavaSourceJarsProvider.class, target); + JavaInfo.getProvider(JavaSourceJarsProvider.class, target); List<String> sourceJars = prettyJarNames(sourcesProvider.getSourceJars()); assertThat(sourceJars).containsExactly("foo/liba-src.jar"); } @@ -435,7 +435,7 @@ public class JavaSkylarkApiTest extends BuildViewTestCase { ); ConfiguredTarget target = getConfiguredTarget("//foo:myrule"); JavaCompilationArgsProvider provider = - JavaProvider.getProvider(JavaCompilationArgsProvider.class, target); + JavaInfo.getProvider(JavaCompilationArgsProvider.class, target); assertThat(provider).isNotNull(); List<String> compileTimeJars = prettyJarNames(provider.getJavaCompilationArgs().getCompileTimeJars()); @@ -475,7 +475,7 @@ public class JavaSkylarkApiTest extends BuildViewTestCase { ); ConfiguredTarget target = getConfiguredTarget("//foo:java_lib"); JavaCompilationArgsProvider provider = - JavaProvider.getProvider(JavaCompilationArgsProvider.class, target); + JavaInfo.getProvider(JavaCompilationArgsProvider.class, target); List<String> compileTimeJars = prettyJarNames( provider.getRecursiveJavaCompilationArgs().getCompileTimeJars()); assertThat(compileTimeJars).containsExactly("foo/libjava_lib-hjar.jar", "foo/liba.jar"); @@ -506,8 +506,8 @@ public class JavaSkylarkApiTest extends BuildViewTestCase { new SkylarkKey(Label.parseAbsolute("//foo:extension.bzl"), "my_provider"); Info declaredProvider = myRuleTarget.get(myProviderKey); Object javaProvider = declaredProvider.getValue("p"); - assertThat(javaProvider).isInstanceOf(JavaProvider.class); - assertThat(javaLibraryTarget.get(JavaProvider.JAVA_PROVIDER)).isEqualTo(javaProvider); + assertThat(javaProvider).isInstanceOf(JavaInfo.class); + assertThat(javaLibraryTarget.get(JavaInfo.PROVIDER)).isEqualTo(javaProvider); } @Test @@ -529,18 +529,18 @@ public class JavaSkylarkApiTest extends BuildViewTestCase { ConfiguredTarget javaLibraryTarget = getConfiguredTarget("//foo:jl"); ConfiguredTarget topJavaLibraryTarget = getConfiguredTarget("//foo:jl_top"); - Object javaProvider = myRuleTarget.get(JavaProvider.JAVA_PROVIDER.getKey()); - assertThat(javaProvider).isInstanceOf(JavaProvider.class); + Object javaProvider = myRuleTarget.get(JavaInfo.PROVIDER.getKey()); + assertThat(javaProvider).isInstanceOf(JavaInfo.class); - JavaProvider jlJavaProvider = javaLibraryTarget.get(JavaProvider.JAVA_PROVIDER); + JavaInfo jlJavaInfo = javaLibraryTarget.get(JavaInfo.PROVIDER); - assertThat(jlJavaProvider == javaProvider).isTrue(); + assertThat(jlJavaInfo == javaProvider).isTrue(); - JavaProvider jlTopJavaProvider = topJavaLibraryTarget.get(JavaProvider.JAVA_PROVIDER); + JavaInfo jlTopJavaInfo = topJavaLibraryTarget.get(JavaInfo.PROVIDER); javaCompilationArgsHaveTheSameParent( - jlJavaProvider.getProvider(JavaCompilationArgsProvider.class).getJavaCompilationArgs(), - jlTopJavaProvider.getProvider(JavaCompilationArgsProvider.class).getJavaCompilationArgs()); + jlJavaInfo.getProvider(JavaCompilationArgsProvider.class).getJavaCompilationArgs(), + jlTopJavaInfo.getProvider(JavaCompilationArgsProvider.class).getJavaCompilationArgs()); } @Test @@ -569,7 +569,7 @@ public class JavaSkylarkApiTest extends BuildViewTestCase { // Test that all bottom jars are on the runtime classpath of lib_exports. ConfiguredTarget jlExports = getConfiguredTarget("//foo:lib_exports"); JavaCompilationArgsProvider jlExportsProvider = - JavaProvider.getProvider(JavaCompilationArgsProvider.class, jlExports); + JavaInfo.getProvider(JavaCompilationArgsProvider.class, jlExports); assertThat(prettyJarNames(jlExportsProvider.getRecursiveJavaCompilationArgs().getRuntimeJars())) .containsAllOf( "foo/libjl_bottom_for_deps.jar", @@ -579,7 +579,7 @@ public class JavaSkylarkApiTest extends BuildViewTestCase { // Test that libjl_bottom_for_exports.jar is in the recursive java compilation args of lib_top. ConfiguredTarget jlTop = getConfiguredTarget("//foo:lib_interm"); JavaCompilationArgsProvider jlTopProvider = - JavaProvider.getProvider(JavaCompilationArgsProvider.class, jlTop); + JavaInfo.getProvider(JavaCompilationArgsProvider.class, jlTop); assertThat(prettyJarNames(jlTopProvider.getRecursiveJavaCompilationArgs().getRuntimeJars())) .contains("foo/libjl_bottom_for_exports.jar"); } @@ -632,7 +632,7 @@ public class JavaSkylarkApiTest extends BuildViewTestCase { // Test that all bottom jars are on the runtime classpath. ConfiguredTarget importTarget = getConfiguredTarget("//foo:import"); JavaCompilationArgsProvider compilationProvider = - JavaProvider.getProvider(JavaCompilationArgsProvider.class, importTarget); + JavaInfo.getProvider(JavaCompilationArgsProvider.class, importTarget); assertThat(prettyJarNames( compilationProvider.getRecursiveJavaCompilationArgs().getRuntimeJars())) .containsAllOf( @@ -666,7 +666,7 @@ public class JavaSkylarkApiTest extends BuildViewTestCase { ConfiguredTarget myRuleTarget = getConfiguredTarget("//foo:custom"); JavaCompilationArgsProvider javaCompilationArgsProvider = - JavaProvider.getProvider(JavaCompilationArgsProvider.class, myRuleTarget); + JavaInfo.getProvider(JavaCompilationArgsProvider.class, myRuleTarget); List<String> directJars = prettyJarNames( javaCompilationArgsProvider.getJavaCompilationArgs().getRuntimeJars()); assertThat(directJars).containsExactly("foo/liba.jar"); @@ -699,7 +699,7 @@ public class JavaSkylarkApiTest extends BuildViewTestCase { ConfiguredTarget myRuleTarget = getConfiguredTarget("//foo:custom"); JavaCompilationArgsProvider javaCompilationArgsProvider = - JavaProvider.getProvider(JavaCompilationArgsProvider.class, myRuleTarget); + JavaInfo.getProvider(JavaCompilationArgsProvider.class, myRuleTarget); List<String> directJars = prettyJarNames( javaCompilationArgsProvider.getJavaCompilationArgs().getRuntimeJars()); assertThat(directJars).containsExactly("foo/liba.jar", "foo/libb.jar"); diff --git a/src/test/java/com/google/devtools/build/lib/rules/java/proto/SkylarkJavaLiteProtoLibraryTest.java b/src/test/java/com/google/devtools/build/lib/rules/java/proto/SkylarkJavaLiteProtoLibraryTest.java index be78678e13..62db959ed1 100644 --- a/src/test/java/com/google/devtools/build/lib/rules/java/proto/SkylarkJavaLiteProtoLibraryTest.java +++ b/src/test/java/com/google/devtools/build/lib/rules/java/proto/SkylarkJavaLiteProtoLibraryTest.java @@ -36,7 +36,7 @@ import com.google.devtools.build.lib.collect.nestedset.NestedSet; import com.google.devtools.build.lib.rules.java.JavaCompilationArgs; import com.google.devtools.build.lib.rules.java.JavaCompilationArgsProvider; import com.google.devtools.build.lib.rules.java.JavaCompileAction; -import com.google.devtools.build.lib.rules.java.JavaProvider; +import com.google.devtools.build.lib.rules.java.JavaInfo; import com.google.devtools.build.lib.rules.java.JavaSourceJarsProvider; import com.google.devtools.build.lib.rules.java.ProguardSpecProvider; import com.google.devtools.build.lib.testutil.MoreAsserts; @@ -586,7 +586,7 @@ public class SkylarkJavaLiteProtoLibraryTest extends BuildViewTestCase { private static <P extends TransitiveInfoProvider> P getProvider( Class<P> providerClass, ConfiguredTarget target) { - JavaProvider javaProvider = target.get(JavaProvider.JAVA_PROVIDER); - return javaProvider.getProvider(providerClass); + JavaInfo javaInfo = target.get(JavaInfo.PROVIDER); + return javaInfo.getProvider(providerClass); } } diff --git a/src/test/java/com/google/devtools/build/lib/rules/test/SkylarkTestingModuleTest.java b/src/test/java/com/google/devtools/build/lib/rules/test/SkylarkTestingModuleTest.java index 2bb09f4789..7d3fa728d8 100644 --- a/src/test/java/com/google/devtools/build/lib/rules/test/SkylarkTestingModuleTest.java +++ b/src/test/java/com/google/devtools/build/lib/rules/test/SkylarkTestingModuleTest.java @@ -16,8 +16,8 @@ package com.google.devtools.build.lib.rules.test; import static com.google.common.truth.Truth.assertThat; import com.google.devtools.build.lib.analysis.ConfiguredTarget; -import com.google.devtools.build.lib.analysis.test.ExecutionInfoProvider; -import com.google.devtools.build.lib.analysis.test.TestEnvironmentProvider; +import com.google.devtools.build.lib.analysis.test.ExecutionInfo; +import com.google.devtools.build.lib.analysis.test.TestEnvironmentInfo; import com.google.devtools.build.lib.analysis.test.TestProvider; import com.google.devtools.build.lib.analysis.test.TestRunnerAction; import com.google.devtools.build.lib.analysis.util.BuildViewTestCase; @@ -49,7 +49,7 @@ public class SkylarkTestingModuleTest extends BuildViewTestCase { ")"); ConfiguredTarget skylarkTarget = getConfiguredTarget("//examples/apple_skylark:my_target"); - ExecutionInfoProvider provider = skylarkTarget.get(ExecutionInfoProvider.SKYLARK_CONSTRUCTOR); + ExecutionInfo provider = skylarkTarget.get(ExecutionInfo.PROVIDER); assertThat(provider.getExecutionInfo().get("requires-darwin")).isEqualTo("1"); } @@ -74,8 +74,8 @@ public class SkylarkTestingModuleTest extends BuildViewTestCase { ")"); ConfiguredTarget skylarkTarget = getConfiguredTarget("//examples/apple_skylark:my_target"); - TestEnvironmentProvider provider = - skylarkTarget.get(TestEnvironmentProvider.SKYLARK_CONSTRUCTOR); + TestEnvironmentInfo provider = + skylarkTarget.get(TestEnvironmentInfo.PROVIDER); assertThat(provider.getEnvironment().get("XCODE_VERSION_OVERRIDE")).isEqualTo("7.3.1"); } diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleContextTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleContextTest.java index 879cd82c0f..7ab868ba66 100644 --- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleContextTest.java +++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleContextTest.java @@ -29,7 +29,7 @@ import com.google.devtools.build.lib.analysis.actions.SpawnAction; import com.google.devtools.build.lib.analysis.skylark.SkylarkRuleContext; import com.google.devtools.build.lib.cmdline.Label; import com.google.devtools.build.lib.packages.Info; -import com.google.devtools.build.lib.rules.java.JavaProvider; +import com.google.devtools.build.lib.rules.java.JavaInfo; import com.google.devtools.build.lib.rules.java.JavaSourceJarsProvider; import com.google.devtools.build.lib.rules.python.PyCommon; import com.google.devtools.build.lib.skylark.util.SkylarkTestCase; @@ -429,7 +429,7 @@ public class SkylarkRuleContextTest extends SkylarkTestCase { Object result = evalRuleContextCode(ruleContext, "ruleContext.attr.srcs"); // Check for a known provider TransitiveInfoCollection tic1 = (TransitiveInfoCollection) ((SkylarkList) result).get(0); - assertThat(JavaProvider.getProvider(JavaSourceJarsProvider.class, tic1)).isNotNull(); + assertThat(JavaInfo.getProvider(JavaSourceJarsProvider.class, tic1)).isNotNull(); // Check an unimplemented provider too assertThat(tic1.get(PyCommon.PYTHON_SKYLARK_PROVIDER_NAME)).isNull(); } diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java index 8b08168b2e..975a98b251 100644 --- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java +++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java @@ -26,7 +26,7 @@ import com.google.devtools.build.lib.actions.CompositeRunfilesSupplier; import com.google.devtools.build.lib.actions.RunfilesSupplier; import com.google.devtools.build.lib.actions.util.ActionsTestUtil; import com.google.devtools.build.lib.analysis.ConfiguredTarget; -import com.google.devtools.build.lib.analysis.DefaultProvider; +import com.google.devtools.build.lib.analysis.DefaultInfo; import com.google.devtools.build.lib.analysis.FilesToRunProvider; import com.google.devtools.build.lib.analysis.Runfiles; import com.google.devtools.build.lib.analysis.actions.FileWriteAction; @@ -910,9 +910,9 @@ public class SkylarkRuleImplementationFunctionsTest extends SkylarkTestCase { assertThat((Boolean) configuredTarget.get("is_provided")).isTrue(); Object provider = configuredTarget.get("provider"); - assertThat(provider).isInstanceOf(DefaultProvider.class); + assertThat(provider).isInstanceOf(DefaultInfo.class); assertThat(((Info) provider).getProvider().getKey()) - .isEqualTo(DefaultProvider.SKYLARK_CONSTRUCTOR.getKey()); + .isEqualTo(DefaultInfo.PROVIDER.getKey()); assertThat(configuredTarget.get("dir")) .isEqualTo( @@ -987,9 +987,9 @@ public class SkylarkRuleImplementationFunctionsTest extends SkylarkTestCase { assertThat((Boolean) configuredTarget.get("is_provided")).isTrue(); Object provider = configuredTarget.get("provider"); - assertThat(provider).isInstanceOf(DefaultProvider.class); + assertThat(provider).isInstanceOf(DefaultInfo.class); assertThat(((Info) provider).getProvider().getKey()) - .isEqualTo(DefaultProvider.SKYLARK_CONSTRUCTOR.getKey()); + .isEqualTo(DefaultInfo.PROVIDER.getKey()); assertThat(configuredTarget.get("dir")) .isEqualTo( @@ -1080,9 +1080,9 @@ public class SkylarkRuleImplementationFunctionsTest extends SkylarkTestCase { assertThat((Boolean) configuredTarget.get("is_provided")).isTrue(); Object provider = configuredTarget.get("provider"); - assertThat(provider).isInstanceOf(DefaultProvider.class); + assertThat(provider).isInstanceOf(DefaultInfo.class); assertThat(((Info) provider).getProvider().getKey()) - .isEqualTo(DefaultProvider.SKYLARK_CONSTRUCTOR.getKey()); + .isEqualTo(DefaultInfo.PROVIDER.getKey()); assertThat(configuredTarget.get("dir")) .isEqualTo( @@ -1143,9 +1143,9 @@ public class SkylarkRuleImplementationFunctionsTest extends SkylarkTestCase { "bar_rule(name = 'my_rule', deps = [':dep_rule'])"); ConfiguredTarget configuredTarget = getConfiguredTarget("//test:my_rule"); Object provider = configuredTarget.get("default"); - assertThat(provider).isInstanceOf(DefaultProvider.class); + assertThat(provider).isInstanceOf(DefaultInfo.class); assertThat(((Info) provider).getProvider().getKey()) - .isEqualTo(DefaultProvider.SKYLARK_CONSTRUCTOR.getKey()); + .isEqualTo(DefaultInfo.PROVIDER.getKey()); } @Test diff --git a/src/test/java/com/google/devtools/build/lib/testutil/TestRuleClassProvider.java b/src/test/java/com/google/devtools/build/lib/testutil/TestRuleClassProvider.java index 22e6d0b413..7e5263454e 100644 --- a/src/test/java/com/google/devtools/build/lib/testutil/TestRuleClassProvider.java +++ b/src/test/java/com/google/devtools/build/lib/testutil/TestRuleClassProvider.java @@ -25,7 +25,7 @@ import com.google.common.collect.ImmutableMap; import com.google.devtools.build.lib.analysis.BaseRuleClasses; import com.google.devtools.build.lib.analysis.ConfiguredRuleClassProvider; import com.google.devtools.build.lib.analysis.ConfiguredTarget; -import com.google.devtools.build.lib.analysis.MakeVariableProvider; +import com.google.devtools.build.lib.analysis.MakeVariableInfo; import com.google.devtools.build.lib.analysis.RuleConfiguredTargetBuilder; import com.google.devtools.build.lib.analysis.RuleConfiguredTargetFactory; import com.google.devtools.build.lib.analysis.RuleContext; @@ -133,7 +133,7 @@ public class TestRuleClassProvider { @Override public ConfiguredTarget create(RuleContext ruleContext) throws InterruptedException, RuleErrorException { - MakeVariableProvider variables = new MakeVariableProvider(ImmutableMap.of( + MakeVariableInfo variables = new MakeVariableInfo(ImmutableMap.of( "TEST_VARIABLE", "FOOBAR")); return new RuleConfiguredTargetBuilder(ruleContext) .setFilesToBuild(NestedSetBuilder.emptySet(Order.STABLE_ORDER)) @@ -150,7 +150,7 @@ public class TestRuleClassProvider { @Override public RuleClass build(Builder builder, RuleDefinitionEnvironment environment) { return builder - .advertiseProvider(MakeVariableProvider.class) + .advertiseProvider(MakeVariableInfo.class) .build(); } |