diff options
| author |  hlopko <hlopko@google.com> | 2017-04-20 17:11:00 +0200 |
|---|---|---|
| committer |  Vladimir Moskva <vladmos@google.com> | 2017-04-24 16:47:12 +0200 |
| commit | 27a136b9bbb4d73b0a343d407b5da9f890175aea (patch) | |
| tree | 804af7885233ba62c0097969a3ff6ad44c1708ba /src/test | |
| parent | e684392afc06a07c4fe6885c9eca7795c35e44c4 (diff) | |
Initialize FeatureConfiguration for hip toolchain when building hip
Before, we correctly replaced CppConfiguration with HipCppConfiguration for hip
builds, but we didn't update FeatureConfiguration. As Blaze was not using
action_configs for compile actions, compiler tool was taken from configuration
at the action creation time, not from FeatureConfiguration, so the tool was
correct. Command line flags (some of them) were computed by
FeatureConfiguration, but luckily the toolchains were so similar that it
worked.
In https://github.com/bazelbuild/bazel/commit/e1d692e486a2f838c3c894fd9de693fabd6685ed I tried to use action_configs for compile actions. The result
was that compiler tool was taken from configuration at the CppConfiguration
creation time, that was put into FeatureConfiguration, and that was used in
action creation time. Sadly, the tool in CppConfiguration was different that
the tool in HipCppConfiguration, and b/37315875 was discovered.
This cl also uppdates FeatureConfiguration when HipCppConfiguration is
replaced.
RELNOTES: None.
PiperOrigin-RevId: 153710405
Diffstat (limited to 'src/test')
0 files changed, 0 insertions, 0 deletions