aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/test
diff options
context:
space:
mode:
authorGravatar laurentlb <laurentlb@google.com>2018-04-12 09:27:57 -0700
committerGravatar Copybara-Service <copybara-piper@google.com>2018-04-12 09:29:35 -0700
commit2213d92c8ddaed701ee4ac8b349877cece9384d0 (patch)
tree58798a8a734815c5411ca5d4869f95b7a3929d13 /src/test
parentb30f2163f44f139403fea755877cd0d0be050060 (diff)
Remove flag `incompatible_disallow_toplevel_if_statement`.
RELNOTES: Removed flag `--incompatible_disallow_toplevel_if_statement`. PiperOrigin-RevId: 192621765
Diffstat (limited to 'src/test')
-rw-r--r--src/test/java/com/google/devtools/build/lib/packages/SkylarkSemanticsConsistencyTest.java2
-rw-r--r--src/test/java/com/google/devtools/build/lib/syntax/ValidationTest.java7
2 files changed, 0 insertions, 9 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/packages/SkylarkSemanticsConsistencyTest.java b/src/test/java/com/google/devtools/build/lib/packages/SkylarkSemanticsConsistencyTest.java
index 97983940f5..057a7b7319 100644
--- a/src/test/java/com/google/devtools/build/lib/packages/SkylarkSemanticsConsistencyTest.java
+++ b/src/test/java/com/google/devtools/build/lib/packages/SkylarkSemanticsConsistencyTest.java
@@ -127,7 +127,6 @@ public class SkylarkSemanticsConsistencyTest {
"--incompatible_disallow_dict_plus=" + rand.nextBoolean(),
"--incompatible_disallow_old_style_args_add=" + rand.nextBoolean(),
"--incompatible_disallow_slash_operator=" + rand.nextBoolean(),
- "--incompatible_disallow_toplevel_if_statement=" + rand.nextBoolean(),
"--incompatible_new_actions_api=" + rand.nextBoolean(),
"--incompatible_package_name_is_a_function=" + rand.nextBoolean(),
"--incompatible_remove_native_git_repository=" + rand.nextBoolean(),
@@ -151,7 +150,6 @@ public class SkylarkSemanticsConsistencyTest {
.incompatibleDisallowDictPlus(rand.nextBoolean())
.incompatibleDisallowOldStyleArgsAdd(rand.nextBoolean())
.incompatibleDisallowSlashOperator(rand.nextBoolean())
- .incompatibleDisallowToplevelIfStatement(rand.nextBoolean())
.incompatibleNewActionsApi(rand.nextBoolean())
.incompatiblePackageNameIsAFunction(rand.nextBoolean())
.incompatibleRemoveNativeGitRepository(rand.nextBoolean())
diff --git a/src/test/java/com/google/devtools/build/lib/syntax/ValidationTest.java b/src/test/java/com/google/devtools/build/lib/syntax/ValidationTest.java
index 773627d9c1..6e352ac15b 100644
--- a/src/test/java/com/google/devtools/build/lib/syntax/ValidationTest.java
+++ b/src/test/java/com/google/devtools/build/lib/syntax/ValidationTest.java
@@ -66,17 +66,10 @@ public class ValidationTest extends EvaluationTestCase {
@Test
public void testForbiddenToplevelIfStatement() throws Exception {
- env = newEnvironmentWithSkylarkOptions("--incompatible_disallow_toplevel_if_statement=true");
checkError("if statements are not allowed at the top level", "if True: a = 2");
}
@Test
- public void testAllowedToplevelIfStatement() throws Exception {
- env = newEnvironmentWithSkylarkOptions("--incompatible_disallow_toplevel_if_statement=false");
- parse("if True: a = 5");
- }
-
- @Test
public void testTwoFunctionsWithTheSameName() throws Exception {
checkError(
"Variable foo is read only", "def foo():", " return 1", "def foo(x, y):", " return 1");