Add all the sources to //:srcs filegroup and add a check to detect

missing file to it.

We need to activate this check on presubmits

--
Change-Id: Ia95e92d3816ce92bb69bc0e2cf56e9c60b68d970
Reviewed-on: https://bazel-review.googlesource.com/#/c/3949/
MOS_MIGRATED_REVID=126404792

5 files changed, 37 insertions, 1 deletions

diff --git a/src/test/shell/BUILD b/src/test/shell/BUILD
index 4055e4469b..95c387b055 100644
--- a/src/test/shell/BUILD
+++ b/src/test/shell/BUILD
@@ -1,5 +1,14 @@
 package(default_visibility = ["//visibility:private"])
 
+filegroup(
+    name = "srcs",
+    srcs = glob(["**"]) + [
+        "//src/test/shell/bazel:srcs",
+        "//src/test/shell/integration:srcs",
+    ],
+    visibility = ["//src:__pkg__"],
+)
+
 sh_library(
     name = "bashunit",
     srcs = ["unittest.bash"],
diff --git a/src/test/shell/bazel/BUILD b/src/test/shell/bazel/BUILD
index 40b34bc359..e064d72f87 100644
--- a/src/test/shell/bazel/BUILD
+++ b/src/test/shell/bazel/BUILD
@@ -1,5 +1,14 @@
 package(default_visibility = ["//visibility:private"])
 
+filegroup(
+    name = "srcs",
+    srcs = glob(["**"]) + [
+        "//src/test/shell/bazel/android:srcs",
+        "//src/test/shell/bazel/testdata:srcs",
+    ],
+    visibility = ["//src/test/shell:__pkg__"],
+)
+
 genrule(
     name = "langtools-copy",
     testonly = 1,
@@ -60,7 +69,7 @@ filegroup(
         "//src/test/shell:bashunit",
         "//third_party:srcs",
         "//third_party/ijar",
-        "//third_party/java/jdk/langtools:srcs",
+        "//third_party/java/jdk/langtools:test-srcs",
         "//tools:srcs",
     ],
     visibility = [
diff --git a/src/test/shell/bazel/android/BUILD b/src/test/shell/bazel/android/BUILD
index 16243889ff..26c155a568 100644
--- a/src/test/shell/bazel/android/BUILD
+++ b/src/test/shell/bazel/android/BUILD
@@ -1,3 +1,9 @@
+filegroup(
+    name = "srcs",
+    srcs = glob(["**"]),
+    visibility = ["//src/test/shell/bazel:__pkg__"],
+)
+
 sh_test(
     name = "android_integration_test",
     size = "large",
diff --git a/src/test/shell/bazel/testdata/BUILD b/src/test/shell/bazel/testdata/BUILD
index 6064737e6d..c3e91a5e31 100644
--- a/src/test/shell/bazel/testdata/BUILD
+++ b/src/test/shell/bazel/testdata/BUILD
@@ -1,4 +1,10 @@
 filegroup(
+    name = "srcs",
+    srcs = glob(["**"]),
+    visibility = ["//src/test/shell/bazel:__pkg__"],
+)
+
+filegroup(
     name = "git-repos",
     testonly = 1,
     srcs = [
diff --git a/src/test/shell/integration/BUILD b/src/test/shell/integration/BUILD
index 768f19096d..35958d4ce7 100644
--- a/src/test/shell/integration/BUILD
+++ b/src/test/shell/integration/BUILD
@@ -1,6 +1,12 @@
 package(default_visibility = ["//visibility:private"])
 
 filegroup(
+    name = "srcs",
+    srcs = glob(["**"]),
+    visibility = ["//src/test/shell:__pkg__"],
+)
+
+filegroup(
     name = "test-deps",
     testonly = 1,
     srcs = [